Gradient color stop sorting is not stable.

[pulkomandy]

Consider the following code used to create a stripped pattern using a BGradient:

gradient.AddColor(black, 0);
gradient.AddColor(black, 127);
gradient.AddColor(white, 127);
gradient.AddColor(white, 255);

In ConvertToScreenForDrawing, the gradient stops will be sorted using BList.Sort. The sorting algorithm is not stable, so the two middle stops may be swapped. There are two ways to fix this:

• Implement a stable sorting algorithm (​http://en.wikipedia.org/wiki/Category:Stable_sorts)
• Remove the AddColorStop method index parameter and use code similar to AddColor to find the proper index, or make that method private. This would allow BGradient to keep the list sorted, and remove the need for sorting it later. The method is used only in app_server (for reading the gradient data from app_server link) and when unarchiving a gradient.

What is the preferred solution?

[pulkomandy]

Fixed in hrev47193.