Opened 5 years ago

Closed 4 years ago

#10840 closed bug (fixed)

Apps not abiding GUI colour definitions

Reported by: humdinger Owned by: Janus
Priority: normal Milestone: R1
Component: Applications Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by diver)

This is hrev47206.

After tweaking

B_MENU_SELECTED_BACKGROUND_COLOR
B_MENU_SELECTED_ITEM_TEXT_COLOR
B_LIST_SELECTED_BACKGROUND_COLOR
B_LIST_SELECTED_ITEM_TEXT_COLOR

(see #10834), I found these apps and preferences not using the changed colours:

Debugger.png

Devices.png

DriveSetup.png

FileTypes.png

HaikuDepot.png

I-O-M.png

Media.png

MediaPlayer-Playlist.png

Printers.png

ProcessController.png

Shortcuts.png

Sounds.png

Time.png

WebPositive.png

I'll attach a screenshot of each one.

Attachments (23)

Debugger.png (34.5 KB) - added by humdinger 5 years ago.
Debugger.png
Devices.png (25.1 KB) - added by humdinger 5 years ago.
Devices.png
DriveSetup.png (27.4 KB) - added by humdinger 5 years ago.
DriveSetup.png
FileTypes.png (33.1 KB) - added by humdinger 5 years ago.
FileTypes.png
HaikuDepot.png (36.0 KB) - added by humdinger 5 years ago.
HaikuDepot.png
I-O-M.png (8.9 KB) - added by humdinger 5 years ago.
I-O-M.png
Media.png (11.0 KB) - added by humdinger 5 years ago.
Media.png
MediaPlayer-Playlist.png (13.1 KB) - added by humdinger 5 years ago.
MediaPlayer-Playlist.png
Printers.png (13.4 KB) - added by humdinger 5 years ago.
Printers.png
ProcessController.png (39.8 KB) - added by humdinger 5 years ago.
ProcessController.png
Shortcuts.png (964.1 KB) - added by humdinger 5 years ago.
Shortcuts.png
Sounds.png (14.1 KB) - added by humdinger 5 years ago.
Sounds.png
Time.png (22.0 KB) - added by humdinger 5 years ago.
Time.png
WebPositive.png (29.9 KB) - added by humdinger 5 years ago.
WebPositive.png
0001-Use-user-color-for-selected-listItem-in-FileTypes-Me.patch (3.5 KB) - added by Janus 4 years ago.
0001-Use-user-color-for-selected-menuItem-in-ProcessContr.patch (5.3 KB) - added by Janus 4 years ago.
Default.png (56.0 KB) - added by Janus 4 years ago.
BColumnListView with user color support.png (60.2 KB) - added by Janus 4 years ago.
BColumnListView with user color support (Window without focus).png (59.2 KB) - added by Janus 4 years ago.
BColumnListView with keyboard selection.png (62.2 KB) - added by Janus 4 years ago.
Time.2.png (38.9 KB) - added by Janus 4 years ago.
Time without seconds delimiter.png (39.2 KB) - added by Janus 4 years ago.
Time with seconds.png (38.8 KB) - added by Janus 4 years ago.

Download all attachments as: .zip

Change History (44)

Changed 5 years ago by humdinger

Attachment: Debugger.png added

Debugger.png

Changed 5 years ago by humdinger

Attachment: Devices.png added

Devices.png

Changed 5 years ago by humdinger

Attachment: DriveSetup.png added

DriveSetup.png

Changed 5 years ago by humdinger

Attachment: FileTypes.png added

FileTypes.png

Changed 5 years ago by humdinger

Attachment: HaikuDepot.png added

HaikuDepot.png

Changed 5 years ago by humdinger

Attachment: I-O-M.png added

I-O-M.png

Changed 5 years ago by humdinger

Attachment: Media.png added

Media.png

Changed 5 years ago by humdinger

Attachment: MediaPlayer-Playlist.png added

MediaPlayer-Playlist.png

Changed 5 years ago by humdinger

Attachment: Printers.png added

Printers.png

Changed 5 years ago by humdinger

Attachment: ProcessController.png added

ProcessController.png

Changed 5 years ago by humdinger

Attachment: Shortcuts.png added

Shortcuts.png

Changed 5 years ago by humdinger

Attachment: Sounds.png added

Sounds.png

Changed 5 years ago by humdinger

Attachment: Time.png added

Time.png

Changed 5 years ago by humdinger

Attachment: WebPositive.png added

WebPositive.png

comment:1 Changed 5 years ago by waddlesplash

The one for Web+ looks correct to me; as for most of the others, it looks like problems in the ColumnListView and TreeView implementations.

comment:2 Changed 5 years ago by pulkomandy

Web+ seems to be using the menu selection color for this highlight, which is a bit unexpected. But I think our color constant list doesn't have a better choice...

comment:3 Changed 5 years ago by diver

Description: modified (diff)

comment:4 Changed 5 years ago by jessicah

Owner: changed from nobody to jessicah
Status: newassigned

comment:5 Changed 5 years ago by humdinger

Tracker ignores colour settings as well, apparently.

comment:6 Changed 4 years ago by Janus

hrev49002 fixes the listItems in:

  • FileTypes
  • Media
  • Printers

menuItems in:

  • ProcessController

BColumnListView needs more thoughts.

Last edited 4 years ago by Janus (previous) (diff)

comment:7 Changed 4 years ago by Janus

hrev49053 fixes the WebPositive AdressBar.

Still to Fix BColumnListView, MediaPlayer and Icon-O-Matic Lists. For Time I don't know which color we should use.

comment:8 Changed 4 years ago by humdinger

I'd say using B_LIST_SELECTED_BACKGROUND_COLOR and B_LIST_SELECTED_ITEM_TEXT_COLOR for the selected day/month/year/time in the first tab would be adequate.

Changed 4 years ago by Janus

Attachment: Default.png added

comment:9 Changed 4 years ago by Janus

This is the current status the B_LIST_SELECTED_BACKGROUND_COLOR is darker (153, 153, 153) the BColumnListView selection is hardcoded (190, 190, 190).

Changed 4 years ago by Janus

comment:10 Changed 4 years ago by Janus

This is the BColumnListView using the B_LIST_SELECTED_BACKGROUND_COLOR choose by the user.

comment:11 Changed 4 years ago by Janus

In BColumnListView when the window lost focus the selected item is rendered with a lighter tint. This doesn't happen with list item.

Changed 4 years ago by Janus

Changed 4 years ago by Janus

Attachment: Time.2.png added

comment:12 Changed 4 years ago by Janus

humdinger do you expect this result?

comment:13 in reply to:  8 Changed 4 years ago by Janus

Replying to humdinger:

I'd say using B_LIST_SELECTED_BACKGROUND_COLOR and B_LIST_SELECTED_ITEM_TEXT_COLOR for the selected day/month/year/time in the first tab would be adequate.

If you want to use the B_LIST_SELECTED_BACKGROUND_COLOR in the spinners I think is inappropriate. Maybe we should use the B_MENU_SELECTED_BACKGROUND_COLOR. (Not sure)

Last edited 4 years ago by Janus (previous) (diff)

comment:14 Changed 4 years ago by humdinger

Yep, Time looks good. Not sure B_MENU_*_*_COLOR would be be more appropriate for the date spinner row on top than B_LIST_*_*_COLOR. It is a bit like a horizontal list, so one could argue for the latter...

BTW, have you noticed that the spinner row on top of the clock let's you also select the delimiters ":"? There's also another ":" to separate the seconds. But seconds aren't displayed, because that's not needed. Should I open another ticket for that or do you see a quick fix, while you're in that corner of the code anyway?

Changed 4 years ago by Janus

comment:15 Changed 4 years ago by Janus

I keep the spinners as they are for now, probably the best fit would be B_CONTROL_* unused at the moment in the UI. I suggested B_MENU_* not for a functional prospective but for a better color mix. The B_MENU_* grey should be darker than the B_LIST_* (the brain perceives difference). A grey on white look darker than the same grey on a lighter grey.

Without the delimiter the view look very ugly :-( What do you think?

Changed 4 years ago by Janus

Attachment: Time with seconds.png added

comment:16 Changed 4 years ago by Janus

With seconds looks good. I cannot find in the history why they were removed.

Last edited 4 years ago by Janus (previous) (diff)

comment:17 Changed 4 years ago by humdinger

You're right. Reintroduce the seconds to make it look better, though it probably isn't used other than by extreme cases of OCD... :) I'd say with network time, all these settings aren't really used much anyway...

comment:18 Changed 4 years ago by Janus

BColumnListView fixed in hrev49144

comment:19 Changed 4 years ago by Janus

MediaPlayer playlist fixed in hrev49145.

comment:20 Changed 4 years ago by jessicah

Owner: changed from jessicah to Janus

comment:21 Changed 4 years ago by Janus

Resolution: fixed
Status: assignedclosed

Fixed in hrev49256.

Note: See TracTickets for help on using tickets.