Apps not abiding GUI colour definitions

[humdinger]

This is hrev47206.

After tweaking

B_MENU_SELECTED_BACKGROUND_COLOR
B_MENU_SELECTED_ITEM_TEXT_COLOR
B_LIST_SELECTED_BACKGROUND_COLOR
B_LIST_SELECTED_ITEM_TEXT_COLOR

(see #10834), I found these apps and preferences not using the changed colours:

I'll attach a screenshot of each one.

[humdinger]

Debugger.png

[humdinger]

Devices.png

[humdinger]

DriveSetup.png

[humdinger]

FileTypes.png

[humdinger]

HaikuDepot.png

[humdinger]

I-O-M.png

[humdinger]

Media.png

[humdinger]

MediaPlayer-Playlist.png

[humdinger]

Printers.png

[humdinger]

ProcessController.png

[humdinger]

Shortcuts.png

[humdinger]

Sounds.png

[humdinger]

Time.png

[humdinger]

WebPositive.png

[waddlesplash]

The one for Web+ looks correct to me; as for most of the others, it looks like problems in the ColumnListView and TreeView implementations.

[pulkomandy]

Web+ seems to be using the menu selection color for this highlight, which is a bit unexpected. But I think our color constant list doesn't have a better choice...

[humdinger]

Tracker ignores colour settings as well, apparently.

[Janus]

hrev49002 fixes the listItems in:

• FileTypes
• Media
• Printers

menuItems in:

• ProcessController

BColumnListView needs more thoughts.

[Janus]

hrev49053 fixes the WebPositive AdressBar.

Still to Fix BColumnListView, MediaPlayer and Icon-O-Matic Lists. For Time I don't know which color we should use.

[humdinger]

I'd say using B_LIST_SELECTED_BACKGROUND_COLOR and B_LIST_SELECTED_ITEM_TEXT_COLOR for the selected day/month/year/time in the first tab would be adequate.

[Janus]

This is the current status the B_LIST_SELECTED_BACKGROUND_COLOR is darker (153, 153, 153) the BColumnListView selection is hardcoded (190, 190, 190).

[Janus]

This is the BColumnListView using the B_LIST_SELECTED_BACKGROUND_COLOR choose by the user.

[Janus]

In BColumnListView when the window lost focus the selected item is rendered with a lighter tint. This doesn't happen with list item.

[Janus]

humdinger do you expect this result?

[Janus]

Replying to humdinger:

I'd say using B_LIST_SELECTED_BACKGROUND_COLOR and B_LIST_SELECTED_ITEM_TEXT_COLOR for the selected day/month/year/time in the first tab would be adequate.

If you want to use the B_LIST_SELECTED_BACKGROUND_COLOR in the spinners I think is inappropriate. Maybe we should use the B_MENU_SELECTED_BACKGROUND_COLOR. (Not sure)

[humdinger]

Yep, Time looks good. Not sure B_MENU_*_*_COLOR would be be more appropriate for the date spinner row on top than B_LIST_*_*_COLOR. It is a bit like a horizontal list, so one could argue for the latter...

BTW, have you noticed that the spinner row on top of the clock let's you also select the delimiters ":"? There's also another ":" to separate the seconds. But seconds aren't displayed, because that's not needed. Should I open another ticket for that or do you see a quick fix, while you're in that corner of the code anyway?

[Janus]

I keep the spinners as they are for now, probably the best fit would be B_CONTROL_* unused at the moment in the UI. I suggested B_MENU_* not for a functional prospective but for a better color mix. The B_MENU_* grey should be darker than the B_LIST_* (the brain perceives difference). A grey on white look darker than the same grey on a lighter grey.

Without the delimiter the view look very ugly :-( What do you think?

[Janus]

With seconds looks good. I cannot find in the history why they were removed.

[humdinger]

You're right. Reintroduce the seconds to make it look better, though it probably isn't used other than by extreme cases of OCD... :) I'd say with network time, all these settings aren't really used much anyway...

[Janus]

BColumnListView fixed in hrev49144

[Janus]

MediaPlayer playlist fixed in hrev49145.

[Janus]

Fixed in hrev49256.