Opened 12 years ago

Closed 10 years ago

#1089 closed bug (fixed)

Appearance doesn't do anything

Reported by: jackburton Owned by: darkwyrm
Priority: normal Milestone: R1
Component: Preferences/Appearance Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

If I change the colors using the appearance preflet, nothing happens. The old colors are still used throghout the system. Moreover, if I close and reopen the app, the colors are resetted to the default ones.

Attachments (1)

patch_decorator (2.6 KB) - added by stpere 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by jackburton

AFAIK appearance now works a bit more.

comment:2 Changed 11 years ago by diver

Appearance is somewhat works, I didn't tested all options, but some of them clearly work, btw shouldn't it be renamed to Colors?

comment:3 Changed 11 years ago by laplace

The bugs in the Appearance preflet should be fixed in hrev27347.

Applying the changes system wide however does not work correctly. 1) Some changes need a repaint request (like scroll bars) 2) Other require restart of the application

I think in R5 was no protocol defined for notification of applications about ui_color changes. So 2 should be the behavior in Haiku.

comment:4 Changed 11 years ago by netster403

Quick note: The Appearance dialog still does not change the color for window tab's as of hrev28136

Changed 10 years ago by stpere

Attachment: patch_decorator added

comment:5 Changed 10 years ago by stpere

Regarding the impossibility to change the color of the tabs ..

There was two errors :

  • It didn't read the colors from the desktop settings passed in the allocator.. instead it read it from ..??? an other desktop settings instance?
  • The Zoom and Close buttons bitmaps didn't store the color it was used to generate them, so changing the color wouldn't trigger a new redraw of them..

My patch fixes those two issues. After that patch, you can change the color in appearance preflet and NEW windows will show the new tab color. However, already opened ones won't change. We need a feedback mecanism to inform the windows that the color scheme changed. We have a similar mecanism to inform them that fonts changed, we might want to copy/adapt it.

comment:6 Changed 10 years ago by stippi

This patch looks good, you can apply it yourself now! :-)

comment:7 Changed 10 years ago by stpere

I applied my patch in hrev30279. I'm not quite sure this ticket should be closed, although, since it covers a wider area than what was fixed with my patch.

comment:8 Changed 10 years ago by stpere

Resolution: fixed
Status: newclosed

We still can't change the color of an already existing tab.. but that would imply a mecanism to advertise changes in themes/styles/colors/appearance to the applications.. But I think that's outside the scope of this ticket, IMO. I'm closing it, as fixed. Feel free to reopen otherwise.

Note: See TracTickets for help on using tickets.