Use query for "Local" depot

[humdinger]

This is hrev47407.

HaikuDepot's "Depot" pop-up menu has an item "Local", that currently seems to filter the list to all locally installed packages. It's identical to choosing "Installed packages" from the "Show" pop-up menu that also holds the different categories.

I propose having a query for all HPKGs on all mounted volumes for the "Local" depot instead. All HPKGs that are not currently installed should show the status "Available" and should be installable, like any other (online) package.

[anevilyak]

They're actually not identical, though it's not apparent outside of the right circumstances: Local will show you *all* locally installed packages regardless of source, while the other will filter against the selected repository. In other words, if you manually install a package from say, a USB stick or one that you handrolled yourself, or whatnot, that would be visible in 'Local', but not elsewhere.

In any case, relying on a query would be problematic as it would only find packages on queryable volumes, ergo it wouldn't find them on a USB stick, or an NFS volume, or a non-indexed BFS like many of us have for development performance reasons. As such I'd be a bit hesitant to use one to display a supposedly all-encompassing list of local but not installed packages. Furthermore it'd potentially be a bit on the slow side for various reasons, as compared to the more or less instant response of the other current list types.

[humdinger]

Thanks for the clarification. Still, "Local" doesn't strike me as a very obvious title. I do realize, though, that a good naming is difficult...

Maybe the pop-up's label shouldn't be "Depot", but "Source" or (as that could be misunderstood meaning source code) "Origin". Instead of "Local" the setting could be "Non-depot origin". I dunno... Maybe someone else comes up with something better.

[luroh]

HaikuDepot's menus have been reworked, closing as no longer valid.