Opened 5 years ago

Closed 5 years ago

#11003 closed enhancement (fixed)

[Debugger] Relocate source file path

Reported by: bonefish Owned by: anevilyak
Priority: normal Milestone: R1
Component: Applications/Debugger Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

With the new handy option to select a source file path from queried results it is relatively easy to accidentally choose a wrong path. An option to fix the resulting mismatch would be good. The tooltip over the path still suggests that clicking it would allow to choose the path, BTW.

Change History (5)

comment:1 Changed 5 years ago by anevilyak

Would it perhaps alternatively work to add a confirmation when picking a result from the queried list (I.e. reduce the likelihood of picking the wrong thing to begin with)? In any case, will look into both issues once I have everything set up at home again.

comment:2 Changed 5 years ago by bonefish

There's always a chance that at the time one actually thinks the selected one is the correct one (e.g. when one has several check-outs of the sources). Adding a confirmation dialog wouldn't help in this case, and in the most likely case that the correct source file was chosen it would be an annoyance.

Showing the context menu regardless of whether a source path is already known might be the easiest and least confusing solution.

comment:3 in reply to:  2 Changed 5 years ago by anevilyak

Status: newin-progress

Replying to bonefish:

Showing the context menu regardless of whether a source path is already known might be the easiest and least confusing solution.

Sounds reasonable, will go with that for now. In any case, need to think about this one a bit, several layers along the chain try to be lazy and do nothing if a source file is already loaded, so I need to decide the best way to persuade them that the file they already have is incorrect and reload. Perhaps it might be easiest to add a listener hook to invalidate the given source file (i.e. force both the file manager and the corresponding source code to release their references and reset their state to not loaded), not sure yet.

comment:4 Changed 5 years ago by anevilyak

Tooltip issue should be fixed as of hrev47485.

comment:5 Changed 5 years ago by anevilyak

Resolution: fixed
Status: in-progressclosed

Remaining portion implemented in hrev47766.

Note: See TracTickets for help on using tickets.