Opened 5 years ago

Closed 5 years ago

#11015 closed bug (invalid)

[PATCHes] AboutSystem credits improvements

Reported by: waddlesplash Owned by: nobody
Priority: normal Milestone: R1
Component: Applications/AboutSystem Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

NOTE: Don't close this ticket after applying the patch. I have more to send, I'm just uploading things a patch at a time to make sure I'm doing things right. I'll close the ticket when I'm finished.

Attachments (4)

0001-AboutSystem-move-authors-and-translators-info-into-A.patch (18.9 KB) - added by waddlesplash 5 years ago.
Part 1.
0001-AboutSystem-move-authors-and-translators-info-to-Cre.patch (19.2 KB) - added by waddlesplash 5 years ago.
Patch file v2.
0003-AboutSystem-use-parens-instead-of-dashes-to-indicate.patch (5.5 KB) - added by waddlesplash 5 years ago.
Third patch.
0002-AboutSystem-remove-outsourced-software.patch (9.1 KB) - added by waddlesplash 5 years ago.
Second patch.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by waddlesplash

Part 1.

comment:1 Changed 5 years ago by waddlesplash

Has a Patch: set

Changed 5 years ago by waddlesplash

Patch file v2.

Changed 5 years ago by waddlesplash

Third patch.

Changed 5 years ago by waddlesplash

Second patch.

comment:2 Changed 5 years ago by axeld

Forgot to note: applied 0001, and 0003 in hrev47550. I currently don't have the time to look into 0002 to see if it's correct. Maybe someone else could do that in the mean time.

comment:3 Changed 5 years ago by umccullough

I'm not sure it's wise to remove credits for 3rd party software that Haiku relies on in order to function. In several cases (such as FreeType), those credits were added per the license requirements. Considering that those packages are pre-installed with Haiku in order for it to function (even if they're separate packages), it makes sense to just include them in our AboutSystem. Our packaging solution does not disclaim us from this.

comment:4 Changed 5 years ago by bonefish

I'd say that AboutSystem should gather the license info from the installed packages. If not from all packages, then at least from the ones the haiku system packages depend on.

comment:5 Changed 5 years ago by waddlesplash

Fine with me. This ticket can be closed as fixed then.

comment:6 Changed 5 years ago by scottmc

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.