#11053 closed enhancement (fixed)
ActivityMonitor: MiB value of network speed (easy)
| Reported by: | dsjonny | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications/ActivityMonitor | Version: | R1/Development |
| Keywords: | gsoc2015 | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
If the network speed is greater than 1024 KiB than it displays in MiB.
Tested, works fine.
Patch has been added.
Attachments (2)
Change History (14)
by , 10 years ago
| Attachment: | 0001-Display-network-speed-in-MiB-if-the-speed-is-higher-.patch added |
|---|
comment:1 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 10 years ago
comment:3 by , 10 years ago
| patch: | 1 → 0 |
|---|
comment:4 by , 10 years ago
I'm sorry, but I don't know how to use the string_for_rate (http://cgit.haiku-os.org/haiku/tree/headers/private/shared/StringForRate.h) function in this case.
comment:5 by , 10 years ago
const char rateString[16]; string_for_rate(rate, rateString, sizeof(rateString)); // now rateString contains "15.5 KiB/s" or similar, already localized and with the most suitable unit
comment:7 by , 10 years ago
| Summary: | ActivityMonitor: MiB value of network speed → ActivityMonitor: MiB value of network speed (easy) |
|---|
Fixed my code in the comment above. Marking ticket as easy since there is little left to do here.
comment:8 by , 10 years ago
Based on the suggestions by pulkomandy I have created a patch. Kindly review it :)
comment:9 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:10 by , 10 years ago
| patch: | 1 → 0 |
|---|
by , 10 years ago
| Attachment: | 0001-Display-network-speed-in-MiB-gsoc15.patch added |
|---|
Style changes made as per Haiku Guidlines
comment:11 by , 10 years ago
| Keywords: | gsoc2015 added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Applied in hrev48660.
comment:12 by , 10 years ago
| patch: | 0 → 1 |
|---|
Note:
See TracTickets
for help on using tickets.
Plase use string_for_rate (defined in headers/private/shared/StringForRate.h) instead of writing custom code for this and requiring the i18n people to translate "KiB/s" and "MiB/s" over and over again in each and every app.