Opened 5 years ago

Closed 9 months ago

#11134 closed bug (no change required)

BSnow messaging wrong BView of Tracker

Reported by: humdinger Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Applications Version: R1/Development
Keywords: BSnow Cc: mmu_man, jscopione
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev 47697.

BSnow currently refuses to quit snowing and doesn't display the "Click me to quit"-button. That is because the messaging addresses Tracker's view 1 and not 0.
I have attached a patch to correct this. I'm not sure however, if all this isn't just a sideeffect pointing to some unwanted change in Tracker...

Attachments (1)

0001-BSnow-apparently-has-to-message-Tracker-s-BView-0-no.patch (1.2 KB ) - added by humdinger 5 years ago.
patching messaging view from #0 -> #1

Download all attachments as: .zip

Change History (5)

by humdinger, 5 years ago

patching messaging view from #0 -> #1

comment:1 by pulkomandy, 5 years ago

It probably is, the window creation order may have changed. Identifying the view by creation order sounds quite fragile, BSnow should probably lookup the view by name instead.

And, Tracker should also be fixed so the view order is preserved, in case other tracker add-ons rely on that.

comment:2 by axeld, 5 years ago

I don't think the order of the view has to be preserved, at least not at all costs. If it's not too unconvenient, sure why not, but things like the navigator might make things a bit random, anyway.

It's much better to look up the view by name as Adrien suggested. At least it's more or less easily possible to keep this one compatible, and that should be the only allowed way to address views within Tracker windows, if you really have to do that.

comment:3 by luroh, 5 years ago

Milestone: R1Unscheduled

Moving out of R1 milestone. BSnow was removed from the default image in hrev47911.

comment:4 by humdinger, 9 months ago

Resolution: no change required
Status: newclosed

It was even moved from the Haiku source to HaikuArchives with hrev49974.

Note: See TracTickets for help on using tickets.