Opened 5 years ago

Closed 5 years ago

#11158 closed enhancement (fixed)

[PATCH] Template Makefile fixes

Reported by: waddlesplash Owned by: nobody
Priority: normal Milestone: R1
Component: System Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

As the commit message says: reformatted, rewrapped lines, removed unsupported stuff ("APP_VERSION"), fixed spelling errors and misinformation.

Attachments (1)

0001-Template-Makefile-fix-wording-rewrap-bump-version-ca.patch (23.4 KB ) - added by waddlesplash 5 years ago.
Git patch.

Download all attachments as: .zip

Change History (4)

comment:1 by waddlesplash, 5 years ago

Has a Patch: set

comment:2 by pulkomandy, 5 years ago

For the record, we discussed this over IRC:

  • Typos/whitespace/casing changes look ok
  • The removal of APP_VERSION is debatable, we should probably re-add the setversion call to the engine if it isn't already there.

comment:3 by pulkomandy, 5 years ago

Resolution: fixed
Status: newclosed

Applied in hrev47874.

Note: See TracTickets for help on using tickets.