Opened 10 years ago
Closed 3 years ago
#11316 closed enhancement (fixed)
[HaikuDepot] defaults to ru in Rate package window
Reported by: | diver | Owned by: | stippi |
---|---|---|---|
Priority: | low | Milestone: | R1/beta4 |
Component: | Applications/HaikuDepot | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
This is hrev47960.
My locale is set to English, however, when I select WonderBrush and click Rate package... button then Comment language is set to "ru".
Attachments (1)
Change History (6)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
by , 10 years ago
Attachment: | haikudepot.png added |
---|
comment:3 by , 10 years ago
Priority: | normal → low |
---|---|
Type: | bug → enhancement |
Thanks, I know what is going on now. The current preferred system language is the default for new ratings. You are however editing an existing rating. This one has the language already set. I should probably change that so it ignores the existing rating language if you edit a rating which has an empty comment. Instead, it would switch to your current system language, assuming that if you type some text, it would be in this language, not in your "old" system language that was current when you first created the rating.
comment:4 by , 4 years ago
Milestone: | R1 → R1.1 |
---|
comment:5 by , 3 years ago
Milestone: | R1.1 → R1/beta4 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fix merged in hrev55461.
The Locale Kit documentation says that the first language returned from the API is the user's preferred language. HaikuDepot uses the first language for the rating comment as the default. The preferred language is read from the system at each start of HaikuDepot and not persistent.
See: http://cgit.haiku-os.org/haiku/tree/src/apps/haikudepot/model/Model.cpp#n362 http://cgit.haiku-os.org/haiku/tree/src/apps/haikudepot/ui/RatePackageWindow.cpp#n236
Can you attach a screenshot of the Locale preflet showing the list of your preferred languages?