Opened 5 years ago

Last modified 5 years ago

#11316 new enhancement

[HaikuDepot] defaults to ru in Rate package window

Reported by: diver Owned by: stippi
Priority: low Milestone: R1
Component: Applications/HaikuDepot Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev47960.

My locale is set to English, however, when I select WonderBrush and click Rate package... button then Comment language is set to "ru".

Attachments (1)

haikudepot.png (244.4 KB ) - added by diver 5 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by stippi, 5 years ago

The Locale Kit documentation says that the first language returned from the API is the user's preferred language. HaikuDepot uses the first language for the rating comment as the default. The preferred language is read from the system at each start of HaikuDepot and not persistent.

See: http://cgit.haiku-os.org/haiku/tree/src/apps/haikudepot/model/Model.cpp#n362 http://cgit.haiku-os.org/haiku/tree/src/apps/haikudepot/ui/RatePackageWindow.cpp#n236

Can you attach a screenshot of the Locale preflet showing the list of your preferred languages?

comment:2 by diver, 5 years ago

I think I know what's going on. I had previously rated WonderBrush to see how ratings work. It may very well be that I was using Russian locale at the time. Now that I've removed my rating it still defaults to ru...

by diver, 5 years ago

Attachment: haikudepot.png added

comment:3 by stippi, 5 years ago

Priority: normallow
Type: bugenhancement

Thanks, I know what is going on now. The current preferred system language is the default for new ratings. You are however editing an existing rating. This one has the language already set. I should probably change that so it ignores the existing rating language if you edit a rating which has an empty comment. Instead, it would switch to your current system language, assuming that if you type some text, it would be in this language, not in your "old" system language that was current when you first created the rating.

Note: See TracTickets for help on using tickets.