Opened 5 years ago

Closed 8 months ago

#11419 closed bug (fixed)

makefile_engine's install function fails on paths with blanks

Reported by: humdinger Owned by: waddlesplash
Priority: normal Milestone: R1
Component: Build System Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev48228.

This is from the 1st revision of the DuckSaver recipe:

INSTALL()
     mkdir -p $addOnsDir/Screen\ Savers
     make install INSTALL_DIR="$addOnsDir/Screen\\ Savers/"

This creates a package with the screensaver correctly put into "add-ons/Screen Savers/" but also results in a stray folder "add-ons/Screen\ Savers".
I tried different escaping, removing the quotes etc., with no success. I finally did the same work around I've seen in another screen saver recipe:

make install INSTALL_DIR=temp
mv temp/DuckSaver $addOnsDir/Screen\ Savers

So... makefile_engine or haikuporter to blame? (or me? :))

Change History (4)

comment:1 by waddlesplash, 9 months ago

Component: - GeneralBuild System
Owner: changed from nobody to waddlesplash
Status: newassigned

comment:2 by waddlesplash, 9 months ago

Resolution: fixed
Status: assignedclosed

Fixed in hrev52738.

comment:3 by humdinger, 8 months ago

Resolution: fixed
Status: closedreopened

The fix resulted in filenames with spaces to appear 'escaped': , e.g. "Open Origin Package" becomes "Open\ Origin\ Package", see https://github.com/haikuports/haikuports/pull/3580

comment:4 by waddlesplash, 8 months ago

Resolution: fixed
Status: reopenedclosed

Re-fixed properly in hrev52792.

Note: See TracTickets for help on using tickets.