Fix CodingStyle checking tool for cached directories of vcs

[LkpPo]

Hello,

Now that development has migrated to git the checkstyle.py tool crashes when invoked on a file. This patch fixes this behaviour and adds support for the most common VCS if someone want to use the one that prefers to code.

I am looking for a sponsor for review and push the patch, please.

Thank you for your help.

-- Stéphane Aulery

[korli]

I think you can iterate over vcsCacheDirectory and use a try/except.

[LkpPo]

I can also simplify the script by a single loop without exception:

     for name in names:
         if name in vcsCacheDirectory:
             print(name + " cache directory has been ignored")
             names.remove(name)
         else:
             path = os.path.join(dir, name)
             if os.path.isfile(path) and os.path.splitext(name)[1] in extensions:
                 print "adding", path
                 result.append(path)

[korli]

ok, but what's the point in removing name from names then?

[LkpPo]

To avoid recursive exploration of part of the tree in the folder list passed to the function os.path.walk(). See ​https://docs.python.org/2/library/os.path.html for more information.

[pulkomandy]

Hi, Are there plans for an updated version of the patch applying the comments above or should we apply the existing one?

[phoudoin]

Sounds good to me.

[pulkomandy]

Applied in hrev50090.