Opened 10 years ago
Closed 10 years ago
#11552 closed bug (fixed)
libroot: Fix Coverity bug 603224: Missing break in switch
| Reported by: | cdesai | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | System/libroot.so | Version: | R1/Development |
| Keywords: | gci2014 | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
This fixes a bug reported by Coverity
Attachments (1)
Change History (8)
by , 10 years ago
| Attachment: | 0002-libroot-Fix-Coverity-bug-603224-Missing-break-in-swi.patch added |
|---|
comment:1 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 10 years ago
| Keywords: | gci2014 added |
|---|
comment:3 by , 10 years ago
| Component: | - General → System/libroot.so |
|---|---|
| Owner: | changed from to |
comment:4 by , 10 years ago
follow-up: 6 comment:5 by , 10 years ago
Ah, because both minutes and seconds have an upper value of 60?
In that case, I guess adding a simple comment indicating that the fallthrough is intentional would be prudent.
comment:6 by , 10 years ago
Replying to umccullough:
Ah, because both minutes and seconds have an upper value of 60?
Max value of 59 - I'm not awake yet...
comment:7 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Applied a more correct patch for this in hrev48525.
Note:
See TracTickets
for help on using tickets.
At a first glance I'd say the missing
breakis intentional.