Opened 6 years ago

Closed 2 months ago

Last modified 2 months ago

#11639 closed enhancement (fixed)

HaikuDepot's rating visibility misnamed or working too well

Reported by: humdinger Owned by: stippi
Priority: normal Milestone: R1/beta2
Component: Applications/HaikuDepot Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

This is hrev48498.

When you edit an existing rating/comment, there's a checkbox "Other users can see this rating". I expect, that it toggles the visibility of an (embarrassing) comment to other users, but myself, I should always be able to see it. But it toggles it for my user, too...

I think that isnt really a problem, I still find my comment if I try to rate again.
But then the label would be better worded e.g. "Don't publish this rating/comment"

Change History (11)

comment:1 by stippi, 6 years ago

I don't quite agree. Certainly if the rating would be visible for you in the regular Ratings page of the package info area, it would be very confusing with any naming of the label, since that place is like the "preview" or "reference" area. What you see there is what you expect other users to see as well. So even with the current label, I would find it very wrong if users saw their own unpublished ratings in the list with the other, published ratings. And with that established, I find the label "Other users can see this rating" very clear and straight forward. You don't have to wonder what "publish" means (for example you don't have to wonder if it will be removed from the server, or whether "publish" is permanent or can be revoked later). The label as is makes this a simple toggle option which does exactly what it says.

comment:2 by humdinger, 6 years ago

I see your point.
While the "Other users can see this rating" says, as you say, exactly what it does, I think it's nonetheless worded a bit untraditionally. At least to me it sounds somehow backwards in the context of a GUI. I'm sorry I can't express it better... maybe a native speaker can chime in.

This, to me, sounds better "This rating is visible to other users". (Maybe the "This rating is" can even be omitted.)

comment:3 by apl-haiku, 3 months ago

Resolution: invalid
Status: newclosed

The checkbox in question appears to be no longer present in the user interface.

comment:4 by humdinger, 3 months ago

The checkbos still exists. You need to rate a package which exact version you've rated/commented on before. That also means, of course, that you cannot edit a rating/comment of an older version of that package. Is that a problem? I dunno...

Re-open the ticket?

comment:5 by waddlesplash, 3 months ago

Resolution: invalid
Status: closedreopened

comment:6 by apl-haiku, 3 months ago

To avoid complications around this, I suggest that edge-case control around disabling / deleting user-ratings should be left to the web interface. What are your thoughts?

comment:7 by humdinger, 3 months ago

disabling / deleting user-ratings should be left to the web interface. What are your thoughts?

I agree. I suppose it's a very seldomly used feature that doesn't need to be in the HaikuDepot app (even more so, when it's available at HDS). If one day people clamour for it to be in the app, the issue could be revisited.

So, remove that checkbox altogether for now?

comment:8 by apl-haiku, 3 months ago

Yes I think so; I will take a look at what is involved.

comment:9 by apl-haiku, 3 months ago

After some looking into it, it is easier to just rename the label as suggested.

comment:10 by apl-haiku, 2 months ago

Resolution: fixed
Status: reopenedclosed

comment:11 by nielx, 2 months ago

Milestone: R1R1/beta2

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

Note: See TracTickets for help on using tickets.