[HaikuDepot] deselects current package on install/uninstall

[diver]

hrev48586.

After installing or uninstalling a package the selection resets.

[luroh]

I'm merely guessing that another symptom of the same "bug" may be that a package's custom icon will first disappear and then reappear again shortly after having installed the package in question.

[stippi]

I changed it so the selection is preserved at all a few days ago. When a package is installed or deinstalled, this triggers a refresh of all pacakges. That in turn frees the previous PackageInfos and creates new ones. Due to the new code which tries to preserve selection, the previously selected package is not found anymore and I guess that's causing the package to disappear. Before, there was no code trying to maintain the selection and due to reference counting, the PackageInfoView was holding on to an old package info. That would also explain why the icon was not changing before the recent changes.

I am just logging this, so I don't have to think about it again when looking at this ticket later.

[diver]

Can't reproduce after hrev48718.

[diver]

Actually, it did still happen after 45 seconds (along with high CPU usage for several seconds). But not anymore after hrev48721.

[stippi]

Yes, that makes perfect sense. What remains I'd that the scrolloffset of the list is not preserved, but it is a minor problem.