Opened 6 years ago

Closed 3 months ago

Last modified 2 months ago

#11689 closed enhancement (fixed)

HaikuDepot lists should use InterfaceDefs colours

Reported by: humdinger Owned by: stippi
Priority: normal Milestone: R1/beta2
Component: Applications/HaikuDepot Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #12129
Platform: All

Description (last modified by pulkomandy)

This is hrev48584.

HaikuDepot should use the system colours defined in InterfaceDefs.h, esp. B_LIST_SELECTED_BACKGROUND_COLOR and B_LIST_ITEM_TEXT_COLOR and B_LIST_SELECTED_ITEM_TEXT_COLOR.

Change History (7)

comment:1 by pulkomandy, 5 years ago

Description: modified (diff)

comment:2 by humdinger, 5 years ago

Blocking: 12129 added

comment:3 by Janus, 2 years ago

I think this is fixed. Am I wrong?

comment:4 by humdinger, 2 years ago

Had a quick test by changing colours in Appearance while watching the HaikuDepot GUI (love that it's live :) ).

Looks like the only thing left is the use of kLightBlack as a colour constant. I suppose one could just remove those SetHighColor(kLightBlack) calls and it'll use the panel text colour.
Though these texts then appear a bit more stark, because of it being black instead of very dark grey. Doing a sort of panel text colour dependend tinting is difficult/not worth it?

comment:5 by Janus, 2 years ago

Should be fixed, if someone chooses a dark background with white text this does not work. Keep this open!

Last edited 2 years ago by Janus (previous) (diff)

comment:6 by waddlesplash, 3 months ago

Resolution: fixed
Status: newclosed

Fixed in hrev54055.

comment:7 by nielx, 2 months ago

Milestone: R1R1/beta2

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

Note: See TracTickets for help on using tickets.