#11689 closed enhancement (fixed)
HaikuDepot lists should use InterfaceDefs colours
Reported by: | humdinger | Owned by: | stippi |
---|---|---|---|
Priority: | normal | Milestone: | R1/beta2 |
Component: | Applications/HaikuDepot | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | #12129 | |
Platform: | All |
Description (last modified by )
This is hrev48584.
HaikuDepot should use the system colours defined in InterfaceDefs.h, esp. B_LIST_SELECTED_BACKGROUND_COLOR and B_LIST_ITEM_TEXT_COLOR and B_LIST_SELECTED_ITEM_TEXT_COLOR.
Change History (7)
comment:1 by , 10 years ago
Description: | modified (diff) |
---|
comment:2 by , 10 years ago
Blocking: | 12129 added |
---|
comment:3 by , 7 years ago
comment:4 by , 7 years ago
Had a quick test by changing colours in Appearance while watching the HaikuDepot GUI (love that it's live :) ).
Looks like the only thing left is the use of kLightBlack as a colour constant. I suppose one could just remove those SetHighColor(kLightBlack) calls and it'll use the panel text colour.
Though these texts then appear a bit more stark, because of it being black instead of very dark grey. Doing a sort of panel text colour dependend tinting is difficult/not worth it?
comment:5 by , 7 years ago
Should be fixed, if someone chooses a dark background with white text this does not work. Keep this open!
comment:7 by , 5 years ago
Milestone: | R1 → R1/beta2 |
---|
Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone
I think this is fixed. Am I wrong?