Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11698 closed bug (fixed)

[Appearance] Drop a RGBColor in the colors tab doesn't enable the revert button

Reported by: Janus Owned by: darkwyrm
Priority: normal Milestone: R1
Component: Preferences/Appearance Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All


Attachments (1)

0001-Appearance-Fix-11698-Drop-a-RGBColor-enables-the-rev.patch (777 bytes ) - added by Janus 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Janus, 5 years ago

Has a Patch: set

comment:2 by pulkomandy, 5 years ago

Resolution: fixed
Status: newclosed

Fixed in a different way in hrev48605.

comment:3 by Janus, 5 years ago

With this patch you check if there is a change in fonts, colors, look and feel, antialiasing, every time the user selects a color.

comment:4 by pulkomandy, 5 years ago

It behaves exactly the same as your patch did. You added Window()->PostMessage(kMsgUpdate); after the call to _SetCurrentColor. Since all 3 places where _SetCurrentColor was called now had this PostMessage call, it made sense to move it to inside _SetCurrentColor instead, which is what I did.

Did I miss something?

comment:5 by Janus, 5 years ago

Your code is correct, but the case ATTRIBUTE_CHOSEN doesn't need the kMsgUpdate sent to the window. The user selects an entry from the list, no need to check if something is different. Sorry I was reviewing the code by heart when I wrote the comment.

Note: See TracTickets for help on using tickets.