Attachments (1)
Change History (6)
by , 10 years ago
Attachment: | 0001-Appearance-Fix-11698-Drop-a-RGBColor-enables-the-rev.patch added |
---|
comment:1 by , 10 years ago
patch: | 0 → 1 |
---|
comment:2 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 by , 10 years ago
With this patch you check if there is a change in fonts, colors, look and feel, antialiasing, every time the user selects a color.
comment:4 by , 10 years ago
It behaves exactly the same as your patch did. You added Window()->PostMessage(kMsgUpdate); after the call to _SetCurrentColor. Since all 3 places where _SetCurrentColor was called now had this PostMessage call, it made sense to move it to inside _SetCurrentColor instead, which is what I did.
Did I miss something?
comment:5 by , 10 years ago
Your code is correct, but the case ATTRIBUTE_CHOSEN doesn't need the kMsgUpdate sent to the window. The user selects an entry from the list, no need to check if something is different. Sorry I was reviewing the code by heart when I wrote the comment.
Fixed in a different way in hrev48605.