Opened 4 years ago

Closed 4 years ago

#11808 closed enhancement (no change required)

Implement zoom for About this system

Reported by: sambuddhabasu1 Owned by: jscipione
Priority: normal Milestone: R1
Component: Applications/AboutSystem Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Currently the zoom option to switch between manual fit and best fit is not present for the About this system application. This needs to be implemented.

Attachments (1)

0001-Implement-zoom-for-About-this-system-application.patch (1.0 KB) - added by sambuddhabasu1 4 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 4 years ago by sambuddhabasu1

I am currently working on this bug.

comment:2 Changed 4 years ago by sambuddhabasu1

Has a Patch: set

comment:3 Changed 4 years ago by jscipione

Ok great you made the window zoomable, now implement the AboutWindow::Zoom(BPoint where, float width, float height) method so that it zooms helpfully.

comment:4 Changed 4 years ago by sambuddhabasu1

Hi jscipione, I did not quite understand what you meant by implementing a AboutWindow::Zoom so that it zooms helpfully. It would be really helpful if there were any examples or any existing app which implements these kind of functions. On going through the applications code, I found out that the DeskCalc has a FrameResized function. Is it similar to this? Thanks

Last edited 4 years ago by sambuddhabasu1 (previous) (diff)

comment:5 Changed 4 years ago by diver

What is the point of having zoom in About window anyway?

comment:6 Changed 4 years ago by pulkomandy

Resolution: invalid
Status: newclosed

This makes no sense, zooming this window is useless. Closing as invalid.

comment:7 Changed 4 years ago by jscipione

Resolution: invalid
Status: closedreopened

Not so fast

comment:8 Changed 4 years ago by jscipione

Generally you want to zoom so that the content fits nicely on the screen and then make the window as tall as comforatable. I don't know an example in the haiku source code but I did some pretty sophisticated zoom code in the paladin editor that takes into account Deskbar's location and size so as to zoom without covering it.

comment:9 Changed 4 years ago by jscipione

Owner: changed from nobody to jscipione
Status: reopenedassigned

comment:10 Changed 4 years ago by pulkomandy

Then the default implementation does what is right: even at full screen size and ridiculously small font the window won't be wide or high enough to fit the whole text.

I still think it is correct to not have a zoom button at all on AboutSystem.

comment:11 Changed 4 years ago by anevilyak

Agreed, I see no point to it either.

comment:12 Changed 4 years ago by jscipione

Resolution: no change required
Status: assignedclosed
Note: See TracTickets for help on using tickets.