Opened 10 years ago
Closed 10 years ago
#11858 closed bug (fixed)
Unregister the SystemTimeSource when media_addon_server quit.
| Reported by: | Barrett | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Servers/media_addon_server | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
The SystemTimeSource is not unregistered when media_addon_server quit.
Attachments (4)
Change History (10)
by , 10 years ago
| Attachment: | 0001-Unregister-SystemTimeSource-when-the-media_addon_ser.patch added |
|---|
comment:1 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 10 years ago
by , 10 years ago
| Attachment: | 0001-Fix-style-issues-in-MediaAddonServer.patch added |
|---|
comment:3 by , 10 years ago
I've separated the style fixes in a separate patch and fixed what you suggested.
comment:4 by , 10 years ago
Both seem fine to me. debugger() calls in error path aren't recommended in release code though.
by , 10 years ago
| Attachment: | 0002-Unregister-SystemTimeSource-when-the-media_addon_ser.patch added |
|---|
by , 10 years ago
| Attachment: | 0003-Use-ERROR-macro-in-MediaAddonServer-instead-of-debug.patch added |
|---|
comment:5 by , 10 years ago
I've removed the debugger call and attached a patch which removes the remaining.
Note:
See TracTickets
for help on using tickets.
It's usually preferred to separate style changes from actual improvements in two commits.
fPulseRunner and fMonitorHandler should be initialized to NULL in constructor. fPulseRunner construction should be checked with InitCheck(). fMonitorHandler should be deleted on destruction.