Opened 5 years ago

Closed 5 years ago

#11858 closed bug (fixed)

Unregister the SystemTimeSource when media_addon_server quit.

Reported by: Barrett Owned by: axeld
Priority: normal Milestone: R1
Component: Servers/media_addon_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

The SystemTimeSource is not unregistered when media_addon_server quit.

Change History (10)

comment:1 by Barrett, 5 years ago

Has a Patch: set

comment:2 by korli, 5 years ago

It's usually preferred to separate style changes from actual improvements in two commits.

fPulseRunner and fMonitorHandler should be initialized to NULL in constructor. fPulseRunner construction should be checked with InitCheck(). fMonitorHandler should be deleted on destruction.

comment:3 by Barrett, 5 years ago

I've separated the style fixes in a separate patch and fixed what you suggested.

comment:4 by korli, 5 years ago

Both seem fine to me. debugger() calls in error path aren't recommended in release code though.

comment:5 by Barrett, 5 years ago

I've removed the debugger call and attached a patch which removes the remaining.

comment:6 by korli, 5 years ago

Resolution: fixed
Status: newclosed

Applied in hrev48893.

Note: See TracTickets for help on using tickets.