Opened 5 years ago

Closed 4 years ago

#11924 closed enhancement (fixed)

Small GUI improvement to "DNS settings" view

Reported by: humdinger Owned by: axeld
Priority: normal Milestone: Unscheduled
Component: Preferences/Network Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev48942.

  • Remove the "DNS servers" box and only use a horizontal separator above the "Domain" text field. Matches better the apparance of the FTP, SSH, Telnet views.
  • Don't resize the buttons when horizontally resizing the window.

See attached screep capture.

Attachments (4)

capture_1.mkv (767.6 KB ) - added by humdinger 5 years ago.
capture of superfluous box and resizing buttons
DNSview.png (21.2 KB ) - added by humdinger 4 years ago.
screenshot
DNSview.diff (2.8 KB ) - added by humdinger 4 years ago.
diff
Network.png (23.0 KB ) - added by diver 4 years ago.

Download all attachments as: .zip

Change History (14)

by humdinger, 5 years ago

Attachment: capture_1.mkv added

capture of superfluous box and resizing buttons

comment:1 by axeld, 5 years ago

I would then replace the "Server" label with "DNS server", though.

comment:2 by humdinger, 4 years ago

I changed the layout accordingly:

screenshot

I thought I could just replace the BBox with a BView, but that didn't work...
I'd appreciate if anyone could have a quick look at the attached diff, before I commit.

Last edited 4 years ago by humdinger (previous) (diff)

by humdinger, 4 years ago

Attachment: DNSview.png added

screenshot

by humdinger, 4 years ago

Attachment: DNSview.diff added

diff

comment:3 by diver, 4 years ago

Maybe we should use +/- buttons like in Time preflet to make it consistent?

Last edited 4 years ago by diver (previous) (diff)

by diver, 4 years ago

Attachment: Network.png added

comment:4 by humdinger, 4 years ago

If there were only the buttons "Add" and "Remove" it might be a good idea. But there's also "Move up" and "Move down". Currently it looks nice with four equally sized buttons. Making two of them smaller or only having miniscule labels +/- doesn't look that good, IMO. One could argue to use arrows instead of "Move up/down", but personally, I'd prefer clearly labeled buttons, esp. if there is no pressing need to save space.
Also, do not fret, we're still consistent: The FileTypes preflet also sports "Move up/down" buttons. :)

comment:5 by axeld, 4 years ago

From the mockup, I would remove the "DNS Settings" header (that's why I mentioned adding DNS to "Server").

Also, there still should be a horizontal separator between the DNS server, and the domain settings.

in reply to:  5 comment:6 by humdinger, 4 years ago

Replying to axeld:

From the mockup, I would remove the "DNS Settings" header (that's why I mentioned adding DNS to "Server").

It's a screenshot, not a mockup. :) I kept the header, because it's also on all other services (ftp, ssh, telnet). Remove them all?

Also, there still should be a horizontal separator between the DNS server, and the domain settings.

Could be done. Though that would kinda imply that the "Apply" button is only for the domain setting, when it's also for the DNS settings above. Or am I too anal about that?

in reply to:  4 comment:7 by diver, 4 years ago

Replying to humdinger:

If there were only the buttons "Add" and "Remove" it might be a good idea. But there's also "Move up" and "Move down".

List items could be done draggable like it's done in Locale preflet so there would be no need for "Move up" and "Move down" buttons :)

comment:8 by axeld, 4 years ago

Alright, then keep the header, and remove the "DNS" again from "DNS server" :-)

I don't think that a separator would affect the 'reach' of the apply button. The server and domain settings are just two separate things; the host name should be somewhere there, too, along with an option not to clobber any of those values by DHCP.

comment:9 by humdinger, 4 years ago

OK then. I'll make it so...

When we get the host name into the Network panel, it'd be nice to also get the last remaining setting in: the 'hosts' file. I'll add an enhancement ticket for that.

@diver: The drag&drop-to-sort feature will have to wait for a more capable developer. :)
Also, drag&drop is less discoverable than buttons. But I see the convenience.

comment:10 by humdinger, 4 years ago

Resolution: fixed
Status: newclosed

Fixed with hrev49245.

Note: See TracTickets for help on using tickets.