Small GUI improvement to "DNS settings" view

[humdinger]

This is hrev48942.

• Remove the "DNS servers" box and only use a horizontal separator above the "Domain" text field. Matches better the apparance of the FTP, SSH, Telnet views.
• Don't resize the buttons when horizontally resizing the window.

See attached screep capture.

[humdinger]

capture of superfluous box and resizing buttons

[axeld]

I would then replace the "Server" label with "DNS server", though.

[humdinger]

I changed the layout accordingly:

I thought I could just replace the BBox with a BView, but that didn't work...
I'd appreciate if anyone could have a quick look at the attached diff, before I commit.

[humdinger]

screenshot

[humdinger]

diff

[diver]

Maybe we should use +/- buttons like in Time preflet to make it consistent?

[humdinger]

If there were only the buttons "Add" and "Remove" it might be a good idea. But there's also "Move up" and "Move down". Currently it looks nice with four equally sized buttons. Making two of them smaller or only having miniscule labels +/- doesn't look that good, IMO. One could argue to use arrows instead of "Move up/down", but personally, I'd prefer clearly labeled buttons, esp. if there is no pressing need to save space.
Also, do not fret, we're still consistent: The FileTypes preflet also sports "Move up/down" buttons. :)

[axeld]

From the mockup, I would remove the "DNS Settings" header (that's why I mentioned adding DNS to "Server").

Also, there still should be a horizontal separator between the DNS server, and the domain settings.

[humdinger]

Replying to axeld:

From the mockup, I would remove the "DNS Settings" header (that's why I mentioned adding DNS to "Server").

It's a screenshot, not a mockup. :) I kept the header, because it's also on all other services (ftp, ssh, telnet). Remove them all?

Also, there still should be a horizontal separator between the DNS server, and the domain settings.

Could be done. Though that would kinda imply that the "Apply" button is only for the domain setting, when it's also for the DNS settings above. Or am I too anal about that?

[diver]

Replying to humdinger:

If there were only the buttons "Add" and "Remove" it might be a good idea. But there's also "Move up" and "Move down".

List items could be done draggable like it's done in Locale preflet so there would be no need for "Move up" and "Move down" buttons :)

[axeld]

Alright, then keep the header, and remove the "DNS" again from "DNS server" :-)

I don't think that a separator would affect the 'reach' of the apply button. The server and domain settings are just two separate things; the host name should be somewhere there, too, along with an option not to clobber any of those values by DHCP.

[humdinger]

OK then. I'll make it so...

When we get the host name into the Network panel, it'd be nice to also get the last remaining setting in: the 'hosts' file. I'll add an enhancement ticket for that.

@diver: The drag&drop-to-sort feature will have to wait for a more capable developer. :)
Also, drag&drop is less discoverable than buttons. But I see the convenience.

[humdinger]

Fixed with hrev49245.