#11981 closed enhancement (fixed)
[PATCHSET] A few cleanups in media_addon_server
| Reported by: | Barrett | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Servers/media_addon_server | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
I have this cleanup of MediaFilePlayer from a while in the hard disk, i think it can be applied as it's.
Attachments (2)
Change History (6)
comment:1 by , 9 years ago
by , 9 years ago
| Attachment: | 0001-media_addon_server-cleanup-of-MediaFilePlayer.patch added |
|---|
by , 9 years ago
| Attachment: | 0002-MediaFilePlayer-don-t-allocate-fName-in-the-heap-use.patch added |
|---|
comment:3 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In 0001 line19/22 there is a logic reversal, is that intentional (i.e. you meant to fix a bug)? -- The original
returns if the strcmp() results is 0, whereas the patchreturns if the strcmp() result is non-0.Didn't spot anything else, need more "eyes on"; As always, thanks for helping make Haiku's media better :-)