Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11981 closed enhancement (fixed)

[PATCHSET] A few cleanups in media_addon_server

Reported by: Barrett Owned by: axeld
Priority: normal Milestone: R1
Component: Servers/media_addon_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

I have this cleanup of MediaFilePlayer from a while in the hard disk, i think it can be applied as it's.

Attachments (2)

Change History (6)

comment:1 by ttcoder, 4 years ago

In 0001 line19/22 there is a logic reversal, is that intentional (i.e. you meant to fix a bug)? -- The original returns if the strcmp() results is 0, whereas the patch returns if the strcmp() result is non-0.

Didn't spot anything else, need more "eyes on"; As always, thanks for helping make Haiku's media better :-)

comment:2 by Barrett, 4 years ago

Thanks for notifying it!

comment:3 by Barrett, 4 years ago

Resolution: fixed
Status: newclosed

comment:4 by Barrett, 4 years ago

Fixed in hrev49384.

Note: See TracTickets for help on using tickets.