Opened 4 years ago

Closed 4 years ago

#11992 closed enhancement (fixed)

[Patch] Fix GCC 5 logical-not-parentheses warnings.

Reported by: mt Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

GCC 5 (5.1.0-RC-20150412) reports.

/home/haiku/haiku/haiku/src/kits/tracker/SettingsViews.cpp: In member function 'virtual void BPrivate::DesktopSettingsView::MessageReceived(BMessage*)':
/home/haiku/haiku/haiku/src/kits/tracker/SettingsViews.cpp:237:41: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
     !fShowDisksIconRadioButton->Value() == 1);
                                         ^
/home/haiku/haiku/haiku/src/kits/tracker/SettingsViews.cpp:270:51: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
     !fMountVolumesOntoDesktopRadioButton->Value() == 1);
                                                   ^
C/home/haiku/haiku/haiku/src/kits/tracker/TaskLoop.cpp: In member function 'virtual bool BPrivate::PeriodicDelayedTask::RunIfNeeded(bigtime_t)':
/home/haiku/haiku/haiku/src/kits/tracker/TaskLoop.cpp:184:19: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
  if (!currentTime < fRunAfter)
                   ^
/home/haiku/haiku/haiku/src/apps/screenshot/Screenshot.cpp: In member function 'status_t Screenshot::_GetActiveWindowFrame()':
/home/haiku/haiku/haiku/src/apps/screenshot/Screenshot.cpp:311:39: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
       && !windowInfo->show_hide_level > 0) {
                                       ^

Attachments (1)

0004-Fix-GCC-5-logical-not-parentheses-warnings.patch (2.3 KB) - added by mt 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 4 years ago by mt

Has a Patch: set

comment:2 Changed 4 years ago by pulkomandy

Resolution: fixed
Status: newclosed

These have already been fixed in existing code, sorry for not merging your patch earlier.

Note: See TracTickets for help on using tickets.