Opened 5 years ago

Closed 5 years ago

#11994 closed enhancement (fixed)

[Patch] Fix GCC 5 suggest parentheses warning.

Reported by: mt Owned by: waddlesplash
Priority: normal Milestone: Unscheduled
Component: Applications/Workspaces Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

GCC 5 (5.1.0-RC-20150412) reports. 

/home/haiku/haiku/haiku/src/apps/workspaces/Workspaces.cpp: In member function 'virtual void WorkspacesWindow::FrameResized(float, float)':
/home/haiku/haiku/haiku/src/apps/workspaces/Workspaces.cpp:699:17: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Werror=parentheses]
  if (!modifiers() & B_SHIFT_KEY) {
                 ^

Attachments (1)

0005-Fix-GCC-5-suggest-parentheses-warning.patch​ (776 bytes ) - added by mt 5 years ago.

Download all attachments as: .zip

Change History (4)

by mt, 5 years ago

Attachment: 0005-Fix-GCC-5-suggest-parentheses-warning.patch​ added

comment:1 by mt, 5 years ago

Has a Patch: set

comment:2 by waddlesplash, 5 years ago

Owner: changed from axeld to waddlesplash
Status: new → in-progress

comment:3 by waddlesplash, 5 years ago

Resolution: → fixed
Status: in-progress → closed

Applied in hrev49222. Thanks!

Note: See TracTickets for help on using tickets.