Opened 4 years ago

Closed 2 months ago

#12024 closed bug (fixed)

Preflet crashed while trying to select wifi network

Reported by: haiqu Owned by: pulkomandy
Priority: normal Milestone: Unscheduled
Component: Preferences/Network Version: R1/Development
Keywords: preferences Cc:
Blocked By: Blocking: #12023, #14414
Has a Patch: no Platform: All


Using the Network preflet, experienced a crash twice in a row trying to select the network from the dropbox. Attachments.

Attachments (1) (12.1 KB) - added by haiqu 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by diver

Blocking: 12023 added

comment:2 Changed 20 months ago by pulkomandy

The menu is periodically emptied and re-populated with an up to date list of wifi networks. It seems that it does not go fine if you are trying to select an item in the menu at the same time. I'm not sure what to do however, because there doesn't seem to be a way to lock the menu (doing that crashes the app even more easily), nor knowing wether it is open to stop updating it.

Maybe it would be better to not rebuild the menu in Pulse as it is done currently, but use the MenusBeginning hook to populate it just as it opens?

comment:3 Changed 20 months ago by axeld

Since repopulating a menu shouldn't be problematic as long as you don't assume your BMenuItem will still be alive when you get its message (it doesn't seem to be the problem here), I would rather like to see the actual bug being fixed.

comment:4 Changed 20 months ago by pulkomandy

Well, changing items in the BMenu from the main window thread, while the menu is doing its own things as a separate thread, and without any locking, seems a bit strange. Is BMenu really designed for this to work?

Shouldn't we at least lock the menu when adding and removing items from it? Or does it lock the parent window looper when active to avoid such problems?

comment:5 Changed 19 months ago by korli

Keywords: preferences added

comment:6 Changed 19 months ago by waddlesplash

@korli: Why do we need a "preferences" keyword? This is already in a "Preferences" component.

comment:7 Changed 19 months ago by korli

@waddlesplash otherwise this ticket doesn't come up in a trac search "network preferences crash".

comment:8 Changed 3 months ago by waddlesplash

Blocking: 14414 added

comment:9 Changed 2 months ago by waddlesplash

Resolution: fixed
Status: newclosed

Should be fixed with hrev52336.

Note: See TracTickets for help on using tickets.