Zip-O-Matic fails on single folder

[mmu_man]

When used to zip-up a single folder, Zip-O-Matic actually chdir()s to it before running /bin/zip, which then fails to find the folder to zip.

[bbjimmy]

This should be a beta blocker

[haiqu]

There are two levels to this issue. First, as stated correctly above, the chdir() needs to be removed from zipperthread.cpp line 100. Once that is done you'll find that files in the home directory can be zipped but files on another volume will fail as before.

I looked over the code for a while but I don't write C++ and it all looks like spaghetti to me.

p.s. Sorry for the dup, I searched for ZipOMatic without the hyphens.

[AGMS]

It also now (hrev49168) fails to zip up directories with a space in their name. Used to work fine for that on BeOS.

[waddlesplash]

I looked over the code for a while but I don't write C++ and it all looks like spaghetti to me.

I do write C++, and it looks like spaghetti to me too. :P

[waddlesplash]

Fixed in hrev49223.

[waddlesplash]

Reverted in hrev49226. Apparently the real culprit is #12105.

[waddlesplash]

(In #12105) Bumping to 'blocker' priority, as this breaks nearly all Tracker addons.

[haiqu]

This is fixed, but not very satisfactorily. Zipped directories now contain the zip, I'd expect it to be created in the parent directory.

[waddlesplash]

This is not fixed; as you can see by the status being "duplicate" and the "blocked by" not being fixed.

[haiqu]

This isn't a duplicate of #12105 but that *may* be the reason it's not working correctly. I'd keep the ticket open until that is confirmed. Regardless, we do get a zipfile now so it's an improvement.

[waddlesplash]

Did you even read what I wrote? #12105 is the root cause of the issue, it's not a "may or may not be". Reading the source code makes it clear, and debugging ZOM makes it obvious.