Opened 4 years ago

Closed 4 years ago

#12087 closed bug (fixed)

Off by one error in BMessage::SetCurrentSpecifier

Reported by: AGMS Owned by: waddlesplash
Priority: low Milestone: Unscheduled
Component: Kits/Application Kit Version: R1/Development
Keywords: BMessage SetCurrentSpecifier Cc: agmsmith@…
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

While debugging an app that uses scripting, I noticed that the index test in BMessage::SetCurrentSpecifier lets you set the index to be after the last Specifier item.

Attachments (1)

0001-Off-by-one-error-in-BMessage-SetCurrentSpecifier.patch (757 bytes ) - added by AGMS 4 years ago.
Just change the test to be >= count to avoid the bug.

Download all attachments as: .zip

Change History (5)

by AGMS, 4 years ago

Just change the test to be >= count to avoid the bug.

comment:1 by AGMS, 4 years ago

Has a Patch: set

comment:2 by waddlesplash, 4 years ago

LGTM. For any committers reading this, feel free to apply and sign-off-by as me (might be a few days before I get to it).

comment:3 by waddlesplash, 4 years ago

Owner: changed from axeld to waddlesplash
Status: newin-progress

comment:4 by waddlesplash, 4 years ago

Resolution: fixed
Status: in-progressclosed

Applied in hrev49221. Thanks!

Note: See TracTickets for help on using tickets.