Opened 10 years ago
Closed 10 years ago
#12087 closed bug (fixed)
Off by one error in BMessage::SetCurrentSpecifier
| Reported by: | AGMS | Owned by: | waddlesplash |
|---|---|---|---|
| Priority: | low | Milestone: | Unscheduled |
| Component: | Kits/Application Kit | Version: | R1/Development |
| Keywords: | BMessage SetCurrentSpecifier | Cc: | agmsmith@… |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
While debugging an app that uses scripting, I noticed that the index test in BMessage::SetCurrentSpecifier lets you set the index to be after the last Specifier item.
Attachments (1)
Change History (5)
by , 10 years ago
| Attachment: | 0001-Off-by-one-error-in-BMessage-SetCurrentSpecifier.patch added |
|---|
comment:1 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 10 years ago
LGTM. For any committers reading this, feel free to apply and sign-off-by as me (might be a few days before I get to it).
comment:3 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → in-progress |
comment:4 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | in-progress → closed |
Applied in hrev49221. Thanks!
Note:
See TracTickets
for help on using tickets.
Just change the test to be >= count to avoid the bug.