Opened 4 years ago

Last modified 4 weeks ago

#12211 assigned enhancement

ShowImage ProgressWindow is useless

Reported by: mmu_man Owned by: leavengood
Priority: normal Milestone: Unscheduled
Component: Applications/ShowImage Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

  • it never shows up, even when loading 17MB 8000x8000 JPEG files in VirtualBox,
  • it creates a useless BWindow and thread for each open window, so if you open 100 windows at once, you get 200 threads in ShowImage for no benefit.

IMO it should just be removed in favor of a progress bar in the image window, or a barber pole à la Tracker.

Change History (10)

comment:1 Changed 4 years ago by axeld

You misunderstand how it's used: it will only be shown if the translator supports reporting progress. So far, the only translator that does this is the RAW translator.

However, I agree that an integrated progress bar (that only shows a barber pole as in Tracker if the translator does not support the functionality) makes more sense, and is even nicer, too.

comment:2 Changed 4 weeks ago by leavengood

Status: newassigned

I like this idea too. I will keep ownership of the ticket but don't know when I will work on it. Not that saying that 4 years later makes much difference.

comment:3 Changed 4 weeks ago by mmu_man

(lol, I just noticed I opened this ticket myself :D)

Using one extra window each time can eat quite a lot of memory as well.

+1 for the barber pole, it would actually be nice to have the label + barber pole as part of the regular BScrollView, as an optional arg or with setters, so apps wouldn't have to rewrite it. Pe has its own, Tracker has one…

Last edited 4 weeks ago by mmu_man (previous) (diff)

comment:4 Changed 4 weeks ago by leavengood

Yeah, the window wasting is annoying, especially if this only is used for the RAW translator and spends most of the time hidden.

I'd have to get some more opinions about adding the barber pole to BScrollView. Worse case the Tracker one can be moved to the shared kit and then used by ShowImage too.

comment:5 Changed 4 weeks ago by pulkomandy

We have a generic barber pole implementation now (used in both Zip O Matic and HaikuDepot).

comment:6 Changed 4 weeks ago by mmu_man

Hmm I liked the Tracker one more, it's more subtle.

comment:7 Changed 4 weeks ago by pulkomandy

Yes, but this one can work as both barber pole and progress bar, depending on if the translator reports progress or not. And it can be made as small as desired, of course.

comment:8 Changed 4 weeks ago by leavengood

OK, I can use that one.

I guess the final question concerns the behavior of such a bar. I think the options are:

  • show it centered in the main window, but with a delay, to avoid the annoying "flash" if an image loads quickly. Then of course replace it with the image when the image loads.
  • show it in the status bar, probably without any delay, and then hide it when the image is done loading.

I think the first option will be nicer for the user, but maybe harder to implement.

comment:9 Changed 4 weeks ago by humdinger

I think the first option will be nicer for the user, but maybe harder to implement.

Yes, also there isn't a status bar when in fullscreen. :)

comment:10 Changed 4 weeks ago by leavengood

Yeah, that is true, I will go for the better option of having it centered in the main window.

Note: See TracTickets for help on using tickets.