Opened 9 years ago
Closed 9 years ago
#12241 closed enhancement (fixed)
[ShowImage] add Get info shortcut (easy)
Reported by: | diver | Owned by: | leavengood |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Applications/ShowImage | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
It would be nice to be able to press Alt+I to get Tracker's info window regarding currently displayed image.
Attachments (2)
Change History (8)
by , 9 years ago
Attachment: | 0001-12241-Adding-Get-Info-option-to-show-image-tool.patch added |
---|
comment:1 by , 9 years ago
patch: | 0 → 1 |
---|
comment:2 by , 9 years ago
I wanted to take this on as a good started issue to look at as I'm new to Haiku. I didn't realize the exact process yet, but started looking at this, just to get my feet wet in the source code and the system. Hopefully this item is still up for grabs. I added a patch set of the work I've done so far for this.
comment:3 by , 9 years ago
Looks like your coding style doesn't conform to our guidelines (https://www.haiku-os.org/development/coding-guidelines). Also, your commit message should contain the name of the app ("ShowImage") first, followed by a colon, and a complete sentence ending in a period. The ticket number should be in the body of the commit details.
comment:4 by , 9 years ago
More complete code review:
- Indent with tabs (4 columns per tab)
- I would try to fit the menu item in one of the existing parts of the menu (maybe just under "move to trash"?). Putting it in its own section between two separators isn't useful.
- Two blank lines between functions
- Why inserting the method declaration between PrepareForPrint and Print? These two sould like they should stay together in the group of "printing" functions.
by , 9 years ago
Attachment: | 0001-ShowImage-Adds-an-option-to-launch-tracker-file-info.patch added |
---|
Updated to conform to code review guidelines and with fixes
comment:5 by , 9 years ago
I updated the patch to conform to coding guidelines and with above suggestions for better placement. Also updated the commit message. Let me know if there is further feedback.
Adding Get Info to show image tool