Changes to User Agent to Include a Version of the Application

[apl-haiku]

The User-Agent HTTP header is presently "X-HDS-Client", but should be "HaikuDepot/x.y.z" where "x.y.z" is the version of the HaikuDepot application. Stephan; are you able to see if this is OK for me?

[korli]

Several checks are missing. For instance:

if (file.InitCheck() == B_OK) {
...

It's also better when you can exactly include what you need instead of StorageKit.h or AppKit.h.

Also the default constructor is automatically called:

BString WebAppInterface::fUserAgent; 
BLocker WebAppInterface::fUserAgentLocker; 

What I don't understand is why you don't build the user agent string on WebAppInterface construction, instead of lazily. Also why the static keyword? Are there several WebAppInterface instances involved?

[apl-haiku]

I'm building the user agent string as a static member variable because the "WebAppInterface" is instantiated in more than one place in the application and I don't want it to be encumbered with the overhead of reading the application version each time.

I've expanded the includes and added more checks for error states. I've also re-arranged the code a bit to make the error handling less onerous around deriving the version string through early-exit.

Patch re-attached.

[apl-haiku]

Sorry - somehow the last iteration of the patch was the wrong version. I have re-attached the updated patch now.

[waddlesplash]

Applied in hrev49515. Thanks!