Opened 4 years ago

Closed 4 years ago

#12434 closed bug (fixed)

Building unittests fails

Reported by: simonsouth Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This morning jam -q -j2 unittests fails with

src/tests/servers/launch/UtilityTest.cpp: In static member function 'static void UtilityTest::AddTests(BTestSuite&)':
src/tests/servers/launch/UtilityTest.cpp:53:38: error: 'TestEmpty' is not a member of 'UtilityTest'
   "UtilityTest::TestTranslatePath", &UtilityTest::TestEmpty));

This looks like a copy-and-paste error in d9bb9513c5e9b36cd4761fffb6f59e141c8aa692; the line ought to read

   "UtilityTest::TestTranslatePath", &UtilityTest::TestTranslatePath));

Continuing, the build fails again with

/(...)/generated/objects/haiku/x86_64/release/tests/servers/launch/Conditions.o: In function `NetworkAvailableCondition::Test(ConditionContext&) const':
Conditions.cpp:(.text+0x488): undefined reference to `NetworkWatcher::NetworkAvailable(bool)'
collect2: error: ld returned 1 exit status

Here the Jamfile changes in 5f2abaf7df37f5e2e6cab5dffeed209e89759e07 need to be applied to the unit tests as well.

With these two changes the build completes for me. I'm attaching a patch with the fixes.

Attachments (1)

0001-Fix-unittests-build.patch (1.4 KB) - added by simonsouth 4 years ago.
Fix unittests build (2015-10-27)

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by simonsouth

Fix unittests build (2015-10-27)

comment:1 Changed 4 years ago by simonsouth

Has a Patch: set

comment:2 Changed 4 years ago by jscipione

Resolution: fixed
Status: newclosed

Patch applied in hrev49729

(test is WIP)

Note: See TracTickets for help on using tickets.