Opened 5 years ago

Closed 5 years ago

#12572 closed bug (fixed)

[DiskProbe] ProbeView has Panel color instead of Document color

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/DiskProbe Version: R1/Development
Keywords: Cc: looncraz
Blocked By: Blocking:
Platform: All

Description

hrev50001

As in title. The same can be seen in Deskbar preferences. Not sure if it's the same problem though.

Attachments (1)

DiskProbe-DataView-Color.patch (1020 bytes ) - added by looncraz 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by looncraz, 5 years ago

What do you mean about Deskbar preferences? I just compared it to hrev 49638 and I see no difference at all.

The ProbeView colors will be corrected shortly :p

(Thanks for making a ticket for all these little issues).

comment:2 by diver, 5 years ago

See TextControl background for Recent documents/folders/applications in Deskbar preferences.

comment:3 by diver, 5 years ago

Also, was Slider colour seen in Deskbar prefs changed on purpose? And blue border around default button seen in /bin/filepanel?

by looncraz, 5 years ago

comment:4 by looncraz, 5 years ago

patch: 01

in reply to:  2 ; comment:5 by looncraz, 5 years ago

Replying to diver:

See TextControl background for Recent documents/folders/applications in Deskbar preferences.

Interesting. I didn't even see those things there (even in hrev49638... they look like decorations when using an 18pt font :p

I see them again with 12pt. No idea why those would have changed, obviously a custom control. I'll check that out then... as well as making it more font-friendly.

in reply to:  3 comment:6 by looncraz, 5 years ago

Replying to diver:

Also, was Slider colour seen in Deskbar prefs changed on purpose? And blue border around default button seen in /bin/filepanel?

If you mean the hashmarks, they are now using the control mark color, IIRC. We had all these system colors going unused...

The default button border is the control highlight color, and the statusbar uses the control mark color as well. These things are user-configurable. The defaults should change if it is desired for these to look as they once did.

For example, changing the control highlight color to 172, 172, 172 will make the default button look exactly as it did before (pixel-perfect).

in reply to:  5 comment:7 by looncraz, 5 years ago

Replying to looncraz:

Replying to diver:

See TextControl background for Recent documents/folders/applications in Deskbar preferences.

Interesting. I didn't even see those things there (even in hrev49638... they look like decorations when using an 18pt font :p

I see them again with 12pt. No idea why those would have changed, obviously a custom control. I'll check that out then... as well as making it more font-friendly.

I created a ticket for it, and uploaded a patch:

https://dev.haiku-os.org/ticket/12574

comment:8 by jessicah, 5 years ago

Resolution: fixed
Status: newclosed

Applied in hrev50010.

Note: See TracTickets for help on using tickets.