Static colour of legend of ActivityMonitor

[humdinger]

This is hrev50010.

After the big SetColour merge, the text of the legend of ActivityMonitor does no longer change with the Desktop background colour. It used to work like with the icon labels: white on a darker background, black on a brighter background. Now it stays black. See:

[humdinger]

Legend always black

[looncraz]

I'll fix this in a few hours, I know exactly what I did here :p

[looncraz]

CORRECT PATCH

[looncraz]

Replying to looncraz:

Sorry, this is the wrong patch :-/

Second time I've done that...

[jessicah]

With these patches, it's still not sensitive to the background image, from what I can tell. One actually has to change the colour sliders to effect a change in the text labels. Will see what an older install does though...

[jessicah]

Both patches applied in hrev50023. At the very least, these don't make the situation worse :p One can manually change the background colour sliders to change the text colour on the Desktop.

[looncraz]

Replying to jessicah:

With these patches, it's still not sensitive to the background image, from what I can tell. One actually has to change the colour sliders to effect a change in the text labels. Will see what an older install does though...

I don't think it was ever sensitive to the background image itself, that would be a rather complex capability involving image sampling while also taking scaling/position of the background image into account... or just using some alpha :p

[jessicah]

Alright, I'll close the ticket. If humdinger thinks more work is required, then can revisit ;-)

[humdinger]

Thanks for the fix! That's the same behaviour as before, i.e. it depends on the workspace's background colour.