[regression] [Interface Kit] white border around some menus

[diver]

hrev50040.

Some apps now have white border around menus. Take a look at the screenshot of ​FilWip which was taken before recent changes (i.e. hrev49977) As can be seen there was no white border around "Default" menu and dow there is.

[diver]

Another example is menus in Pe's find window.

[looncraz]

This took me a bit to understand what was wrong as it was so rarely occurring, but it was just the fact that we should be adopting the parent view color as the low color. Easily missed because most views' low color is the same as their view color (especially during initialization).

Attaching a patch.

[markh]

Can this patch be applied or is there still something wrong with it?

[looncraz]

Replying to markh:

Can this patch be applied or is there still something wrong with it?

It should probably be applied, it's a really simple fix that restores the intent of the code that existed prior to the application of another patch.

[pulkomandy]

I'm not sure it goes the right way, setting the low color is known to cause flickering in some cases because the view is filled with the low color on invalidation (and then redrawn over that).

Why wouldn't BMenuField drawing use the ViewColor directly instead?

[looncraz]

Replying to pulkomandy:

I'm not sure it goes the right way, setting the low color is known to cause flickering in some cases because the view is filled with the low color on invalidation (and then redrawn over that).

Why wouldn't BMenuField drawing use the ViewColor directly instead?

The low color matches the parent's view color, so it is used to draw a border around the menu when giving it a shape. Usually the view color and the low color are the same.

This method is used for many interface elements without issue (and it is the default BControl behavior). This is also the method deployed prior to the application of the SetViewUIColor patchset.

[waddlesplash]

Applied in hrev50057. Thanks!