Opened 9 years ago
Last modified 8 years ago
#12620 assigned enhancement
Use a map for finding areas in ServerMemoryAllocator
Reported by: | Anarchos | Owned by: | nobody |
---|---|---|---|
Priority: | low | Milestone: | Unscheduled |
Component: | Kits/Application Kit | Version: | R1/Development |
Keywords: | ServerMemoryAllocator | Cc: | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
This is a patch to solve a TODO in src/kits/app/ServerMemoryAllocator.cpp I couldn't test it, but i post it for review here. Don't hesitate to comment !!
Attachments (1)
Change History (7)
by , 9 years ago
Attachment: | 0006-remplacement-BList-par-TODO.patch added |
---|
comment:1 by , 9 years ago
patch: | 0 → 1 |
---|
comment:2 by , 9 years ago
Summary: | Patch to solve a TODO → Use a map for finding areas in ServerMemoryAllocator |
---|
comment:3 by , 9 years ago
Thanks for you contribution. A couple of quick remarks:
- The coding style is questionable. Please have a look at our coding style guidelines (for example, naming of variables). Trying not to make the code stick out would be a good start.
- Your spacing seems to be off -- we use tabs for indentation, not spaces. The spacing in the original file is okay.
- Don't leave commented out code in your patches.
- Please use a typedef for the map.
- What is "!ret_insert.second" supposed to do?
- Instead of std::pair, a dedicated structure would make the code a lot more readable.
- Areas don't seem to be deleted anymore on destruction.
- What's the point in submitting code you didn't even test?
Most issues make your patch very hard to read and evaluate.
comment:4 by , 8 years ago
patch: | 1 → 0 |
---|
comment:5 by , 8 years ago
patch: | 0 → 1 |
---|
Marking the patch as "obsolete", as pointed out by axel above, more work is required.
comment:6 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Note:
See TracTickets
for help on using tickets.
Solving a TODO in ServerMemoryAllocator (UNTESTED)