Opened 4 years ago

Closed 3 years ago

#12662 closed enhancement (fixed)

Silence warnings in png translator build to enable -Werror

Reported by: MichaelCrawford Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #9460
Has a Patch: yes Platform: All

Description

all the warnings are about longjmp possibly clobbering a variable. It should work to declare them all volatile.

Attachments (1)

0001-Declare-certain-variables-as-volaile-to-silence-long.patch (6.0 KB ) - added by MichaelCrawford 4 years ago.
Silenced warnings in PNGTranslator.cpp, enabled -Werror in ArchitectureRules

Download all attachments as: .zip

Change History (4)

comment:1 by MichaelCrawford, 4 years ago

Added "virtual" to certain variables to silence warnings about clobbering by longjmp. Also added const_cast when passing non-virtual function arguments not for declaring non-constness, but for stripping the virtual.

by MichaelCrawford, 4 years ago

Silenced warnings in PNGTranslator.cpp, enabled -Werror in ArchitectureRules

comment:2 by MichaelCrawford, 4 years ago

Has a Patch: set

comment:3 by pulkomandy, 3 years ago

Resolution: fixed
Status: newclosed

Fixed in a different way in hrev50404.

Note: See TracTickets for help on using tickets.