Opened 9 years ago
Closed 8 years ago
#12662 closed enhancement (fixed)
Silence warnings in png translator build to enable -Werror
Reported by: | MichaelCrawford | Owned by: | nobody |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | - General | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | #9460 | |
Platform: | All |
Description
all the warnings are about longjmp possibly clobbering a variable. It should work to declare them all volatile.
Attachments (1)
Change History (4)
comment:1 by , 9 years ago
by , 9 years ago
Attachment: | 0001-Declare-certain-variables-as-volaile-to-silence-long.patch added |
---|
Silenced warnings in PNGTranslator.cpp, enabled -Werror in ArchitectureRules
comment:2 by , 9 years ago
patch: | 0 → 1 |
---|
comment:3 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed in a different way in hrev50404.
Note:
See TracTickets
for help on using tickets.
Added "virtual" to certain variables to silence warnings about clobbering by longjmp. Also added const_cast when passing non-virtual function arguments not for declaring non-constness, but for stripping the virtual.