[GLife] crashes in _mesa_resize_framebuffer

[diver]

hrev50238.

GLife crashes after walking through the list of screensavers up and down.

[phoudoin]

Seems to be with the old mesa_swrast OpenGL renderer, which is not anymore used. Could you check if using mesa_swpipe OpenGL renderer trigger the same issue ?

[diver]

It looks like mesa_swpipe is only available for gcc4.

[pulkomandy]

Yes, for gcc2 we are still using an old Mesa version which has only one rasterizer.

And for gcc4, both renderer are still supported, often you have to try both as they will work or crash in different places, so even there we aren't fully ready to switch to using only the new softpipe.

[phoudoin]

Then why gcc2 only mesa_swrast code was deleted from Mesa source? Where MesaSoftwareRender class code could be found today?

[pulkomandy]

The Mesa used for gcc2 is here: ​https://github.com/haiku/mesa_legacy/commits/7.9 For gcc4 the upstream Mesa repo is used, all our work has been upstreamed.

(or alternatively, TinyGL could be used, but there wasn't much testing of this so I wouldn't recommend it)

[phoudoin]

Thanks. I guess somewhere a sub object is not allocated due to initial width and height being zeros but when it's resized _mesa_resize_framebuffer try to deference renderbuffer which were never allocated in the first place.

Will try to spot where and why.

[cocobean]

GLife/Mesa 17.1.10-2 x86_64 and Mesa 7.9.2-11 gcc2 passed with no crash issues with screensavers.