Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12728 closed bug (fixed)

xhci: invalid max scratchpad

Reported by: kallisti5 Owned by: korli
Priority: normal Milestone: Unscheduled
Component: Drivers/USB/XHCI Version: R1/Development
Keywords: xhci Cc:
Blocked By: Blocking:
Platform: All

Description

In our driver, xhci scratchpads are fixed number, while later xhci 1.1 specs bumped them up. This results in an "Invalid number of scratchpads" error at boot.

xhci scratchpads need to be variable:

https://www.coreboot.org/pipermail/seabios/2015-August/009627.html

http://permalink.gmane.org/gmane.linux.usb.general/116329

XHCI_MAX_SCRATCHPADS

Change History (2)

comment:1 by kallisti5, 9 years ago

Resolution: fixed
Status: newclosed

resolved via hrev50246.

1.1 spec bumped to 36. We actually are looking at number of scratch pads, but we had a low limit of 32 (which was the actual 1.0 count)

hrev50246 increased the maximum to a sane 48

comment:2 by kallisti5, 9 years ago

*cough* make that 1024. While my controller requested 36, the 1.1 spec says the controller can request up to 1023.

Note: See TracTickets for help on using tickets.