#12746 closed bug (fixed)
[Patch] netresolv: fix gcc6 build
| Reported by: | mt | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Kits/Network Kit | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Gcc6 warns some '-Werror=unused-const-variable=', but I don't know if these variables can be really removed. so marked as unused by attribute.
Attachments (2)
Change History (8)
by , 8 years ago
| Attachment: | 0004-netresolv-fix-gcc6-build.patch added |
|---|
comment:1 by , 8 years ago
| patch: | 0 → 1 |
|---|
by , 8 years ago
| Attachment: | netresolv_buildlog.txt added |
|---|
follow-ups: 3 4 comment:2 by , 8 years ago
comment:3 by , 8 years ago
Replying to pulkomandy:
The "rcsid" could be commented out, it is useful to know which version of *BSD we got the files from, but not of any use to the compiler.
The others can be completely removed, if the compiler says so.
Hi, pulkomandy. All rcsids are between #if and #endif, so can I use && !defined(__HAIKU__) to comment out them?
comment:4 by , 8 years ago
Replying to pulkomandy:
The "rcsid" could be commented out, it is useful to know which version of *BSD we got the files from, but not of any use to the compiler.
There is git history for that.
comment:6 by , 7 years ago
rcsid[] in dst/support.c is not guarded with LINT, so we could comment out it for gcc6 build.
http://cgit.haiku-os.org/haiku/tree/src/kits/network/netresolv/dst/support.c#n1
The "rcsid" could be commented out, it is useful to know which version of *BSD we got the files from, but not of any use to the compiler.
The others can be completely removed, if the compiler says so.