Opened 3 years ago

Closed 3 years ago

#12757 closed bug (fixed)

[Patch] debugger: fix gcc6 build

Reported by: mt Owned by: anevilyak
Priority: normal Milestone: Unscheduled
Component: Applications/Debugger Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Reindent source code, to fix gcc6 '-Werror=misleading-indentation' warnings.

/home/haiku/haiku/haiku/src/apps/debugger/debugger_interface/interfaces/LocalDebuggerInterface.cpp: In member function 'virtual status_t LocalDebuggerInterface::GetNextDebugEvent(DebugEvent*&)':
/home/haiku/haiku/haiku/src/apps/debugger/debugger_interface/interfaces/LocalDebuggerInterface.cpp:378:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
     if (message.origin.thread >= 0 && message.origin.nub_port >= 0)
     ^~
/home/haiku/haiku/haiku/src/apps/debugger/debugger_interface/interfaces/LocalDebuggerInterface.cpp:381:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
      if (error != B_OK)
      ^~
cc1plus: all warnings being treated as errors

C++ /home/haiku/haiku/haiku/generated-gcc6/objects/haiku/x86/release/apps/debugger/SettingsMenu.o 
/home/haiku/haiku/haiku/src/apps/debugger/user_interface/gui/util/SettingsMenu.cpp: In member function 'virtual void SettingsMenuImpl::OptionsMenuItem::PrepareToShow(BLooper*, BHandler*, Settings*)':
/home/haiku/haiku/haiku/src/apps/debugger/user_interface/gui/util/SettingsMenu.cpp:182:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if (optionItem != NULL)
    ^~
/home/haiku/haiku/haiku/src/apps/debugger/user_interface/gui/util/SettingsMenu.cpp:186:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     optionItem->SetMarked(optionItem->Option() == selectedOption);
     ^~~~~~~~~~
cc1plus: all warnings being treated as errors

Attachments (1)

0011-debugger-fix-gcc6-build.patch (1.8 KB ) - added by mt 3 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 by mt, 3 years ago

Has a Patch: set

comment:2 by anevilyak, 3 years ago

Resolution: fixed
Status: newclosed

Applied in hrev50299. Thanks!

Note: See TracTickets for help on using tickets.