Opened 8 years ago

Closed 8 years ago

#12766 closed bug (fixed)

[Patch] accelerants/radeon: fix gcc6 build

Reported by: mt Owned by: euan
Priority: normal Milestone: Unscheduled
Component: Drivers/Graphics/radeon Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Reindent source code, to fix gcc6 '-Werror=misleading-indentation' warnings.

Cc /home/haiku/haiku/haiku/generated-gcc6/objects/haiku/x86/release/add-ons/accelerants/radeon/Cursor.o 
/home/haiku/haiku/haiku/src/add-ons/accelerants/radeon/Cursor.c: In function 'moveOneCursor':
/home/haiku/haiku/haiku/src/add-ons/accelerants/radeon/Cursor.c:193:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
     if( y < 0 )
     ^~
/home/haiku/haiku/haiku/src/add-ons/accelerants/radeon/Cursor.c:196:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  if( crtc_idx == 0 ) {
  ^~
cc1: all warnings being treated as errors

Cc /home/haiku/haiku/haiku/generated-gcc6/objects/haiku/x86/release/add-ons/accelerants/radeon/impactv.o 
/home/haiku/haiku/haiku/src/add-ons/accelerants/radeon/impactv.c: In function 'Radeon_CalcImpacTVRegisters':
/home/haiku/haiku/haiku/src/add-ons/accelerants/radeon/impactv.c:512:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
     if( !internal_encoder )
     ^~
/home/haiku/haiku/haiku/src/add-ons/accelerants/radeon/impactv.c:515:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  values->tv_htotal = mode->timing.h_total - 1;
  ^~~~~~
cc1: all warnings being treated as errors

Attachments (1)

0018-accelerants-radeon-fix-gcc6-build.patch (1.6 KB ) - added by mt 8 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by mt, 8 years ago

patch: 01

comment:2 by korli, 8 years ago

+1, but coding style could be improved.

comment:3 by waddlesplash, 8 years ago

Resolution: fixed
Status: newclosed

Applied in hrev50308. Thanks!

Note: See TracTickets for help on using tickets.