Opened 8 years ago
Closed 8 years ago
#12779 closed bug (fixed)
Version info in big endian resource is not handled correctly
| Reported by: | markh | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Kits/Storage Kit | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
When reading the version information of a big endian resource file, the numbers are read as if they are in the host endianess format, so they come out wrong on a little endian machine. For example 1 is shown as 16777216. See the attached resource for an example.
Attachments (3)
Change History (8)
by , 8 years ago
| Attachment: | test_bigendian.rsrc added |
|---|
by , 8 years ago
| Attachment: | 0001-12779-Handle-version-info-in-resource-in-other-endia.patch added |
|---|
comment:1 by , 8 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 8 years ago
comment:3 by , 8 years ago
Some coding style nits:
- Only indent by one tab on continuation lines (lines 332, 1216)
- Since the first block of the if() statements also contains a comment, places {}s around it
by , 8 years ago
| Attachment: | 0001-12779-Handle-version-info-in-resource-in-other-endia.2.patch added |
|---|
Note:
See TracTickets
for help on using tickets.
Added a patch so the ResourceFile class knows what to do with the version info type. This was the best option according to the haiku dev mailing list.