Overlapping SetFocus()

[bxi07354@…]

src/servers/app/Desktop.cpp

Desktop::SetFocusWindow(WindowLayer* focus) 961 lines

if (fFocus != NULL) {

fFocus->SetFocus(false); oldActiveApp = fFocus->ServerWindow()->App();

}

fFocus = focus;

if (fFocus != NULL) {

fFocus->SetFocus(true); newActiveApp = fFocus->ServerWindow()->App();

}

When focus and fFocus are the same SetFocus(false); SetFocus(true); I think it is near and useless.

my code

if (fFocus != NULL && fFocus != focus) {

fFocus->SetFocus(false); oldActiveApp = fFocus->ServerWindow()->App();

}

fFocus = focus;

if (fFocus != NULL && (!fFocus->IsFocus())) {

fFocus->SetFocus(true); newActiveApp = fFocus->ServerWindow()->App();

}

[axeld]

Thanks for noticing!

[bxi07354@…]

Isn't there possibility of focus->IsFocus() == false?

[axeld]

Sorry, I don't understand what you mean. Care to elaborate a bit more in depth? :-)

[bxi07354@…]

Sorry.I am not good at English. if fFocus->IsFocus() is false, it cannot be truly done.