Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#128 closed bug (fixed)

Overlapping SetFocus()

Reported by: bxi07354@… Owned by: axeld
Priority: normal Milestone: R1
Component: - General Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

src/servers/app/Desktop.cpp

Desktop::SetFocusWindow(WindowLayer* focus) 961 lines

if (fFocus != NULL) {

fFocus->SetFocus(false); oldActiveApp = fFocus->ServerWindow()->App();

}

fFocus = focus;

if (fFocus != NULL) {

fFocus->SetFocus(true); newActiveApp = fFocus->ServerWindow()->App();

}

When focus and fFocus are the same SetFocus(false); SetFocus(true); I think it is near and useless.

my code

if (fFocus != NULL && fFocus != focus) {

fFocus->SetFocus(false); oldActiveApp = fFocus->ServerWindow()->App();

}

fFocus = focus;

if (fFocus != NULL && (!fFocus->IsFocus())) {

fFocus->SetFocus(true); newActiveApp = fFocus->ServerWindow()->App();

}

Change History (6)

comment:1 by axeld, 14 years ago

Status: newclosed

comment:2 by axeld, 14 years ago

Resolution: fixed

comment:3 by axeld, 14 years ago

Thanks for noticing!

comment:4 by bxi07354@…, 14 years ago

Isn't there possibility of focus->IsFocus() == false?

comment:5 by axeld, 14 years ago

Sorry, I don't understand what you mean. Care to elaborate a bit more in depth? :-)

comment:6 by bxi07354@…, 14 years ago

Sorry.I am not good at English. if fFocus->IsFocus() is false, it cannot be truly done.

Note: See TracTickets for help on using tickets.