#128 closed bug (fixed)
Overlapping SetFocus()
Reported by: | Owned by: | axeld | |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | - General | Version: | |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
src/servers/app/Desktop.cpp
Desktop::SetFocusWindow(WindowLayer* focus) 961 lines
if (fFocus != NULL) {
fFocus->SetFocus(false); oldActiveApp = fFocus->ServerWindow()->App();
}
fFocus = focus;
if (fFocus != NULL) {
fFocus->SetFocus(true); newActiveApp = fFocus->ServerWindow()->App();
}
When focus and fFocus are the same SetFocus(false); SetFocus(true); I think it is near and useless.
my code
if (fFocus != NULL && fFocus != focus) {
fFocus->SetFocus(false); oldActiveApp = fFocus->ServerWindow()->App();
}
fFocus = focus;
if (fFocus != NULL && (!fFocus->IsFocus())) {
fFocus->SetFocus(true); newActiveApp = fFocus->ServerWindow()->App();
}
Change History (6)
comment:1 by , 19 years ago
Status: | new → closed |
---|
comment:2 by , 19 years ago
Resolution: | → fixed |
---|
comment:3 by , 19 years ago
comment:5 by , 19 years ago
Sorry, I don't understand what you mean. Care to elaborate a bit more in depth? :-)
comment:6 by , 19 years ago
Sorry.I am not good at English. if fFocus->IsFocus() is false, it cannot be truly done.
Thanks for noticing!