[Patch] net_buffer.cpp: Fix clang warning

[mt]

In remove_header(), 'while (left >= 0)' at line 1823 is always true because 'left' is unsigned. so I think we may change condition to 'while (left > 0)'.

/home/haiku/haiku/haiku/src/add-ons/kernel/network/stack/net_buffer.cpp:1823:14: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
        while (left >= 0) {
               ~~~~ ^  ~

[pulkomandy]

I'm not sure this is right, especially as the code inside the loop does handle "left == 0". Either we should make "left" signed, or change the loop into a "while true" if there are other ways to exit it.

[TwoFx]

From my understanding of the code, the only way the loop ought to be exited is through the break statement in line 1827 and the return statement in line 1829. Therefore, putting while (true) should be appropriate. On the other hand, one might argue that while (left >= 0), despite doing nothing in practice, more clearly demonstrates the purpose of the loop (i.e. removing all bytes that are left).

[axeld]

I'd prefer to use a while (true) loop here; especially since leaving it like this produces a warning, and is also slightly confusing for those who expect loop conditions make sense, and don't just hint at the intended usage :-)

In any case, the suggested patch is not correct, and would break the code, nice catch, Adrien!

[axeld]

Fixed in hrev50429. Thanks mt for reporting!