Opened 8 years ago
Closed 8 years ago
#12893 closed bug (fixed)
[Patch] Terminal: Fix -Wlogical-not-parentheses
Reported by: | mt | Owned by: | jackburton |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Applications/Terminal | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Modify if condition at line 1597 [1], since strcmp() returns 0 > or < 0 on failture, negating it may not be 0.
/home/haiku/haiku/haiku/src/apps/terminal/TermView.cpp:1597:8: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] && !strcmp("encoding", ^ /home/haiku/haiku/haiku/src/apps/terminal/TermView.cpp:1597:8: note: add parentheses after the '!' to evaluate the comparison first && !strcmp("encoding", ^ /home/haiku/haiku/haiku/src/apps/terminal/TermView.cpp:1597:8: note: add parentheses around left hand side expression to silence this warning && !strcmp("encoding", ^
Attachments (1)
Change History (3)
by , 8 years ago
Attachment: | 0026-Terminal-Fix-Wlogical-not-parentheses.patch added |
---|
comment:1 by , 8 years ago
patch: | 0 → 1 |
---|
comment:2 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Fixed in hrev50503.