Opened 8 years ago
Closed 13 months ago
#12986 closed enhancement (fixed)
Use half-stars in Tracker's "rating" attribute column (easy)
| Reported by: | pulkomandy | Owned by: | mmu_man |
|---|---|---|---|
| Priority: | low | Milestone: | R1/beta5 |
| Component: | Applications/Tracker | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
The attribute column in Tracker uses unicode stars to show the rating in a semi-graphical way. It uses 5 stars for a rating from 0 to 10.
Unicode will include half-stars in version 11 (http://www.righto.com/2016/10/inspired-by-hn-comment-four-half-star.html). When this is available and supported by our fonts, we should use them to display the odd ratings.
Note that Unicode version 11 is scheduled for june 2018, so we have some time ahead of us.
Attachments (2)
Change History (12)
comment:1 by , 2 years ago
| Summary: | Use half-stars in Tracker's "rating" attribute column → Use half-stars in Tracker's "rating" attribute column (easy) |
|---|
comment:2 by , 13 months ago
by , 13 months ago
| Attachment: | rating_in_stylededit.png added |
|---|
by , 13 months ago
| Attachment: | rating.png added |
|---|
comment:3 by , 13 months ago
There's nothing we can do about this from Haiku side. We should check if we're using the latest version of Noto Sans Symbols, and if the issue is still there in that version, report it here: https://github.com/notofonts/symbols/issues?q=is%3Aissue+is%3Aopen
comment:5 by , 13 months ago
After looking around at the noto github for way too long, I'm not sure what's the current version and how it may compare to our "v20201206-phase3". You can't just remove the file name if the URL in our noto recipe: https://github.com/googlefonts/noto-fonts/archive/v20201206-phase3.tar.gz to see what other versions there are and download those...
Anyone got a clue?
comment:6 by , 13 months ago
OK. Found the URL for the current Noto Sans Display. It's still our version, v20201206-phase3. I'll file the issue now...
comment:7 by , 13 months ago
I think the nono-fonts repo is out of date and the new version is https://github.com/notofonts/symbols/releases/tag/NotoSansSymbols2-v2.008
So we should switch to that (it's from 3 weeks ago, so much newer than what we are using currently).
Download link: https://github.com/notofonts/symbols/releases/download/NotoSansSymbols2-v2.008/NotoSansSymbols2-v2.008.zip
comment:8 by , 13 months ago
Had a quick look. Half-stars are now same size as the full-stars. \o/
Thanks!
comment:9 by , 13 months ago
| Milestone: | Unscheduled → R1/beta5 |
|---|
I have prepared a patch for this that introduces a half star. The unfortunate thing is that the half stars are a tiny bit smaller than the full stars. At least in our Noto Sans font. Have a look:
A bit bigger in StyledEdit:
Can we live with that?