Opened 7 years ago
Closed 7 years ago
#13126 closed bug (fixed)
[Patch] kits/media/PluginManager.cpp: fix memory leak
| Reported by: | mt | Owned by: | Barrett |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Kits/Media Kit | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
In PluginManager::CreateReader(), 'buffered_source' may leak at line 240 [1] if buffered_source->InitCheck() != B_OK. [1] http://cgit.haiku-os.org/haiku/tree/src/kits/media/PluginManager.cpp#n240
Attachments (2)
Change History (6)
by , 7 years ago
| Attachment: | 0038-PluginManager.cpp-fix-memory-leak.patch added |
|---|
comment:1 by , 7 years ago
| patch: | 0 → 1 |
|---|
by , 7 years ago
| Attachment: | report-97294d.html added |
|---|
comment:2 by , 7 years ago
Thanks for the patch!
InitCheck was originally included in the BAdapterIO API and was then dropped and it's actually doing nothing.
The real fix here is to remove completely the InitCheck() function from BMediaIOWrapper and the check in PluginManager.
comment:3 by , 7 years ago
Are you willing to submit an updated patch? Otherwise I'd have to close this ticket and do the work myself.
Note:
See TracTickets
for help on using tickets.
report by Clang Static Analyzer