#13146 closed bug (fixed)

Makefile-engine does not generate catkeys

Reported by: Kacper Kasper Owned by: Nobody
Priority: normal Milestone: Unscheduled
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

I have tried using make catkeys, but it keeps generating empty (30-something bytes) file. collectcatkeys issues warnings when used with -w and I have discovered that there is grep -av '^#' missing after gcc preprocessing step. Other targets use that too, so I assume this is an oversight.

Simple patch attached.

Attachments (1)

makefile-engine-fix.patch (558 bytes) - added by Kacper Kasper 12 months ago.

Download all attachments as: .zip

Change History (4)

Changed 12 months ago by Kacper Kasper

Attachment: makefile-engine-fix.patch added

comment:1 Changed 12 months ago by Kacper Kasper

Has a Patch: set

comment:2 Changed 11 months ago by waddlesplash

Patch looks OK to me; if nobody has any comments, I'll merge it shortly.

comment:3 Changed 11 months ago by waddlesplash

Resolution: fixed
Status: newclosed

Applied in hrev50857. Thanks!

Note: See TracTickets for help on using tickets.