Some mp3 files fail to play on recent builds

[vidrep]

Some mp3 files fail to play on recent Haiku builds. hrev50818 x86_gcc2 Attached are screenshots and sample files which will show the issue.

[AlienSoldier]

Yup, same thing i get on many mp3.

I also get only the first second of sound on at least the youtube 480p video downloaded trough www.keepvid.com

I am also linking an mp3 where i get something different from Vidrep. "File could not be opened, general system error".

[AlienSoldier]

file play in VLC but not mediaplayer

[waddlesplash]

Make "some" into "most" -- all the MP3 files I have which worked on previous builds no longer play. They have a 4-second duration in MediaPlayer despite being of various multi-minute lengths. playfile in Terminal yields:

BMediaTrack::ReadFrames: decoder returned error 0xffffffff (General system error)
playback finished

[AlienSoldier]

" also get only the first second of sound on at least the youtube 480p video downloaded trough www.keepvid.com" that now work again on the hrev50919 build (perhaps worked some rev before). Still have problem with many mp3 that said.

[leszek]

Tested it and it works with hrev50791. So basically everything before the big ffmpeg update of hrev50795 works like a charm. Everything after is either completely broken or most partly broken (only plays a few mp3 files but not the majority of common files)

PS: Replaced the ffmpeg hpkgs from hrev50941 with the ones from hrev50791 and everything works. All my mp3s play without any issue :)

[korli]

Hmm there was also an ffmpeg 0.10 update in hrev50805. IMO it would make more sense to be related to this one because this is the package containing libs used by MediaPlayer on x86_gcc2. hrev50795 is likely unrelated.

[pulkomandy]

Problem tracked to here: ​http://cgit.haiku-os.org/haiku/tree/src/add-ons/media/plugins/ffmpeg/AVFormatReader.cpp#n260

We currently give ".mod" as a file name to ffmpeg when opening anything. This allows playing amiga MOD files, which ffmpeg doesn't have a better way to detect than the file extension. However, now MP3s are also detected as MOD files and played with libmodplug, which has no idea how to handle them.

I tried setting the parameter back to NULL, but then ffmpeg does not detect any format at all and nothing is played.

Setting it to ".mp3", the decoding works fine again.

So, for things to work properly in as much formats as possible, we should get either the MIME type or the file name to this function. Unfortunately, we only get a BDataIO at that level. We can cast it to a BFile, but that still doesn't get us to the filename, we would need a BEntry. An alternative is to sniff the data to try to detect the file type.

[pulkomandy]

Fixed in hrev51058.