[Interface Kit] scrollbars do not scale

[diver]

With large font size most apps look good, however scrollbars do not scale unlike other elements and become tiny on HiDPI screens.

[X512]

Scroll bar size is hardcoded by B_V_SCROLL_BAR_WIDTH, B_H_SCROLL_BAR_HEIGHT. Changing size may break layout in some programs.

[pulkomandy]

Indeed. But I think we can make it work at least with the layout kit.

Some notes:

• The scrollbar code itself in fact has no problem drawing at other sizes, this is just the default and can be overriden.
• We need to adjust the resize knob, which may be tricky because it is handled by the decorators; not by the client drawing.
• We could keep the small size (we will have to, in fact) for old apps that don't use the layout kit, except maybe if they use BScrollView and we can manage the scrollbar size from there, but even then, I'm not sure if we can get it to work. For layout-API apps it is not a problem (once the resize knob is dealt with) to change the size.

[waddlesplash]

Done in hrev54400.

Replies to pulkomandy's notes:

• Indeed, I did not have to change any drawing code.
• I just added scaling to the resize knob based on the application's font size (after all, different applications may have different fonts and font sizes, so the decorators should not give us a scaled minimum resize knob size.)
• As far as I can tell, BScrollView's code compensates for the size the scrollbars take up for the view, so I just enabled the scaling code unconditionally, i.e. even in non-layout mode. Probably most layout-unaware applications will be unusable at large font sizes anyway, but if some are intelligent enough, the scroll view will also look correct.

[X512]

I think that 12.0f value should be not used directly ​here. At least some constant define should be used, for example B_DEFAULT_FONT_SIZE.

[waddlesplash]

There are other places in the code that already use 12.0f. Possibly we should make a constant for that, yes.

[KapiX]

Resize thumb of B_DOCUMENT_WINDOW_LOOK should be scaled as well.

[waddlesplash]

Yes, this is a decorator issue though and so deserves a separate ticket.

[diver]

Scrollbars in Debugger, Sounds, Repositories, Shortcuts, Notifications, HaikuDepot still do not scale. BColumnListView related?

[waddlesplash]

Yes, a separate ticket should be opened for that please.